Use OpenBLAS with updated NUM_THREADS to fix #43008 #43047
Conversation
|
This PR also increases the NUM_THREADS to 512, which has been reasonably tested on master by now, but should be tested much more widely. Since a broken matrix exponential is quite bad, we may want another RC if we want to merge this PR. Otherwise we could also wait to have this in 1.7.1. |
|
What is the resolution here? |
|
We need to get this into 1.7 rc4. I don't see it on |
|
I think this PR was automatically closed by GitHub because the base (target) branch was deleted. |
|
@daviehh Can you rebase this PR on the latest version of the |
daviehh
force-pushed
the
backports-release-1.7
branch
from
4364fdb
to
5dba096
Compare
* Use 4096 NUM_THREADS for OpenBLAS In line with https://github.com/JuliaPackaging/Yggdrasil/blob/master/O/OpenBLAS/common.jl * Fix * Use fewer max threads
|
@DilumAluthge thanks, now just updated against the latest |
|
This PR fixes JuliaSIMD/LoopVectorization.jl#364 on 1.7-branch. On master (1.8)-branch #42708 fixed it. Reason unbeknownst to me. |
KristofferC
force-pushed
the
backports-release-1.7
branch
from
727feea
to
fe216ae
Compare
Tested locally, the OpenBLAS built with 3cc8b0f link1, link2 should fix the StackOverflowError #43008
Following an earlier comment #43013, this PR not a new version of openblas so should be fine now? Possibly need the 1.7 tag since matrix exp is quite important and is now somewhat broken in 1.7.0-rc2. Thanks!