Fix StackOverflowError with matrix exp on 1.7.0-rc2 (fix #43008) #43013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade OpenBLAS to v0.3.17 This allows us to drop several patches. * Precision adjustments in doctests
OpenBLAS binaries built with 512 max threads.
daviehh
changed the title
|
We cannot unfortunately upgrade openblas in julia 1.7 at this point. We need to backport the specific openblas fixes and apply them to openblas 0.3.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked 2 commits to fix #43008
(StackOverflowError when taking complex-valued matrix exp, bumping openblas for a fix)
Hope it's the correct way to do this. Likely need to have the 1.7 tag/backport?
just picking b8ad4f1 does not seem enough, thus also added 6d0b192
5a14037 not included here for now: openblas is usually downloaded, but for cases where it needs to be built from source maybe this mk file needs to be included for consistency