Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #36031: Printf bug for BigInt #36033

Merged
merged 2 commits into from
May 28, 2020

Conversation

simeonschaub
Copy link
Member

@simeonschaub simeonschaub commented May 26, 2020

These were omitted during testing and weren't valid anymore. Should probably be backported as this is a bugfix.
close #36031

@fredrikekre fredrikekre changed the title fix #36031 fix #36031: Printf bug for BigInt May 26, 2020
@simonbyrne simonbyrne mentioned this pull request May 27, 2020
Copy link
Contributor

@simonbyrne simonbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

stdlib/Printf/src/Printf.jl Outdated Show resolved Hide resolved
stdlib/Printf/src/Printf.jl Outdated Show resolved Hide resolved
stdlib/Printf/src/Printf.jl Outdated Show resolved Hide resolved
stdlib/Printf/src/Printf.jl Outdated Show resolved Hide resolved
stdlib/Printf/src/Printf.jl Outdated Show resolved Hide resolved
@simonbyrne simonbyrne merged commit 150311f into JuliaLang:master May 28, 2020
@simonbyrne
Copy link
Contributor

Thanks!

KristofferC pushed a commit that referenced this pull request Jun 1, 2020
* fix #36031

* Apply suggestions from code review

Co-authored-by: Simon Byrne <[email protected]>
(cherry picked from commit 150311f)
simeonschaub added a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
* fix JuliaLang#36031

* Apply suggestions from code review

Co-authored-by: Simon Byrne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printf bug for BigInt
3 participants