Backports for Julia 1.5-RC1 (or beta2) #36098
Conversation
* fix #36031 * Apply suggestions from code review Co-authored-by: Simon Byrne <[email protected]> (cherry picked from commit 150311f)
(cherry picked from commit 7e60e1b)
…35232) * LibGit2: amend GitError enum Since upstream commit libgit2/libgit2@e9cef7c ("http: introduce GIT_ERROR_HTTP") an invalid content type yields a GIT_ERROR_HTTP instead of a GIT_ERROR_NET error. Update the enum to include this new error so that the unit test for LibGit2 doesn't fail with "invalid value for Enum Class: 34". * LibGit2: add resolve_url to RemoteCallbacksStruct for LibGit2 0.99.0 Upstream commit libgit2/libgit2@59647e1 ("remote: add callback to resolve URLs before connecting") introduced a new callback "resolve_url" in LibGit2 0.99.0. Even though it is not currently used in Julia, it needs to be accounted for to get the correct size for FetchOptionsStruct. An incorrectly aligned FetchOptionsStruct leads to error messages like "invalid version 0 on git_proxy_options" when trying to use the latest LibGit2 version. * LibGit2: update error message checking for LibGit2 0.99.0 Upstream commit libgit2/libgit2@b9c5b15 ("http: use the new httpclient") changed the error message to include additional quotes. Relax the unit test to allow these if present. Co-authored-by: Milan Bouchet-Valat <[email protected]> (cherry picked from commit 59a315c)
KristofferC
added
DO NOT MERGE
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
|
@KristofferC I pushed a commit to update the NEWS entry for |
(cherry picked from commit 932a1ec)
* rename pop!(vector, idx, [default]) to popat! * popat! : explain what `default` is (cherry picked from commit 0164101)
(cherry picked from commit 38238c8)
(cherry picked from commit 7385876)
It could only handle a couple of pairs, e.g. ImmutableDict(1=>1, 2=>2, 3=>3) would throw. The fix is implemented by adding the `ImmutableDict(t::ImmutableDict, pairs...)` constructor, which generalizes `ImmutableDict(t::ImmutableDict, pair)` (with some similarity to how `push!` accepts multiple items to be pushed). (cherry picked from commit 162cde1)
(cherry picked from commit 968ccfc)
(cherry picked from commit a6354d9)
|
@nanosoldier |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt |
(cherry picked from commit a51015c)
|
@KristofferC Could you please consider including #35281 in here? |
(cherry picked from commit 0e062e9)
(cherry picked from commit 6c760d2)
* deleteat! : check bounds for the first passed index
All other indices are bound-checked.
Currently, the behavior looks like:
```julia
julia> deleteat!([1:1000;], [-100])
signal (11): Segmentation fault
[...]
julia> deleteat!(BigInt[0], [0])
free(): invalid next size (normal)
signal (6): Aborted
[...]
julia> deleteat!(BigInt[0], [-100])
ERROR: UndefRefError: access to undefined reference
[...]
julia> deleteat!([0], [0])
Int64[]
julia> deleteat!([0], [2])
1-element Array{Int64,1}:
0
julia> deleteat!([0], [3])
ERROR: InexactError: check_top_bit(UInt64, -1)
[...]
```
With this commit, all these expressions throw a `BoundsError`.
* Update base/array.jl
Co-authored-by: Simeon Schaub <[email protected]>
Co-authored-by: Simeon Schaub <[email protected]>
(cherry picked from commit 6cdfcf9)
KristofferC
removed
DO NOT MERGE
KristofferC
changed the title
KristofferC
changed the title
Backported PRs:
-d16->+d32feature change for LLVM 9+ #36061 - Update armv7l-d16->+d32feature change for LLVM 9+showdoc strings #36076 - clarifyshowdoc stringsFoo.Finside structFdefined in moduleFoonow errors with UndefVar error #36104, assign global name during type definitionsinitfromcount!docstring #36305 - Removeinitfromcount!docstringhttpbintests over to JuliaLang-hostedhttpbinmock server #36336 - Switchhttpbintests over to JuliaLang-hostedhttpbinmock serversplatnew#35976 - more precise inference ofsplatnewNon-merged PRs with backport label:
StridedVecOrMat#35929 - Remove unnecessary restriction toStridedVecOrMat