Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix pool size assumption #34554

Merged
merged 1 commit into from
Jan 29, 2020
Merged

test: fix pool size assumption #34554

merged 1 commit into from
Jan 29, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jan 28, 2020

On 32-bit, this object falls into the 12-byte pool, which does not exist
on some platforms (such as Win32). Query for which pool this will land
into and test the track-allocation result accordingly.

@vtjnash vtjnash added priority This should be addressed urgently test This change adds or pertains to unit tests embarrassing-bugfix Whoops! labels Jan 28, 2020
On 32-bit, this object falls into the 12-byte pool, which does not exist
on some platforms (such as Win32). Query for which pool this will land
into and test the track-allocation result accordingly.

Fixes a test added in #34391
@vtjnash
Copy link
Member Author

vtjnash commented Jan 28, 2020

https://build.julialang.org/#/builders/65/builds/7445 seems to be just the usually httpbin test flakiness, restarting it

@vtjnash vtjnash merged commit 27f70f8 into master Jan 29, 2020
@vtjnash vtjnash deleted the jn/34391-test-fix branch January 29, 2020 01:19
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
On 32-bit, this object falls into the 12-byte pool, which does not exist
on some platforms (such as Win32). Query for which pool this will land
into and test the track-allocation result accordingly.

Fixes a test added in #34391
giordano pushed a commit that referenced this pull request Jul 21, 2024
Split out from #54848 where this is necessary as `MAX_ALIGN` is now 16
on x86. Similar change to #34554.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embarrassing-bugfix Whoops! priority This should be addressed urgently test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant