Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win32 track-allocation issues #34545

Closed
staticfloat opened this issue Jan 28, 2020 · 1 comment
Closed

win32 track-allocation issues #34545

staticfloat opened this issue Jan 28, 2020 · 1 comment
Assignees
@vtjnash

Comments

@staticfloat
Copy link
Member

#34391 broke win32, but we didn't notice because the same test file was independently broken and fixed by #34506

Excerpt of error log:

Error in testset cmdlineargs:
Test Failed at D:\buildbot\worker-tabularasa\tester_win32\build\share\julia\test\cmdlineargs.jl:283
  Expression: popfirst!(got) == "       24     Base.invokelatest(g, 0)"
   Evaluated: "       16     Base.invokelatest(g, 0)" == "       24     Base.invokelatest(g, 0)"
Error in testset cmdlineargs:
Test Failed at D:\buildbot\worker-tabularasa\tester_win32\build\share\julia\test\cmdlineargs.jl:284
  Expression: popfirst!(got) == "       36     Base.invokelatest(g, x)"
   Evaluated: "       48     Base.invokelatest(g, x)" == "       36     Base.invokelatest(g, x)"
staticfloat referenced this issue Jan 28, 2020
@vtjnash
track-allocation: charge entry cost to caller (#34391)
91a118e 
Don't include one-time costs (JIT compilation) so that warm-up isn't generally required.
And adjust codegen emission to charge call entry costs to the caller.

fixes #11753
fixes #19981
fixes #21871
fixes #34054
close #18595
@maleadt
Copy link
Member

maleadt commented Jan 29, 2020

Fixed by #34554

@maleadt maleadt closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtjnash vtjnash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@staticfloat @vtjnash @maleadt