Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: getcolptr -> colptrs #33041

Closed
wants to merge 1 commit into from
Closed

Rename: getcolptr -> colptrs #33041

wants to merge 1 commit into from

Conversation

tkf
Copy link
Member

@tkf tkf commented Aug 23, 2019

As @ViralBShah suggested in #32953 (comment), it makes sense to drop get prefix from getcolptr(::SparseMatrixCSC). To be compatible with rowvals and nonzeros, it may be better to use colptrs?

Also, maybe it's better to remove getrowval and getnzval (or deprecate them, if we want to be extra careful) as they are just aliases of rowvals and nonzeros?

See also #33039

@ViralBShah
Copy link
Member

Agree with all the suggestions.

@ViralBShah ViralBShah added the sparse Sparse arrays label Aug 23, 2019
@tkf
Copy link
Member Author

tkf commented Aug 23, 2019

Good to know! Can #33039 and maybe also #33037 (edit: it's merged) go first? This patch is literally just sed -E -i 's/\bgetcolptr\b/colptrs/g' so re-doing this is pretty easy. On the other hand, the other patches are more delicate.

@tkf
Copy link
Member Author

tkf commented Aug 24, 2019

There are other suggestions in #25118. coloffsets makes sense to me.

@tkf
Copy link
Member Author

tkf commented Aug 25, 2019

Let's do this in #33054.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants