Refactoring: Add AbstractSparseMatrixCSC #33039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have accessor-based code to manipulate sparse arrays #32953, we can expose the rich set of functions in SparseArrays.jl in a highly extensible manner by "just" replacing
SparseMatrixCSC
withAbstractSparseMatrixCSC
in appropriate places. This is the second step I discussed with @ViralBShah in #30173 (comment).Quick summary
This patch introduces a new abstract type
AbstractSparseMatrixCSC
julia/stdlib/SparseArrays/src/abstractsparse.jl
Lines 28 to 30 in 89a0c1a
and then declare
SparseMatrixCSC
to be the subtype of itjulia/stdlib/SparseArrays/src/sparsematrix.jl
Line 19 in 89a0c1a
I then apply a series of diffs like below so that the functions previously dispatched on
SparseMatrixCSC
is now dispatched onAbstractSparseMatrixCSC