Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case when norm==Inf in normalize #29691

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Handle case when norm==Inf in normalize #29691

merged 1 commit into from
Oct 19, 2018

Conversation

andreasnoack
Copy link
Member

Fixes #29681

@andreasnoack andreasnoack added linear algebra Linear algebra bugfix This change fixes an existing bug backport pending 1.0 labels Oct 17, 2018
@andreasnoack andreasnoack merged commit 0ba31aa into master Oct 19, 2018
@andreasnoack andreasnoack deleted the an/normalize branch October 19, 2018 11:23
@wsshin
Copy link
Contributor

wsshin commented Oct 19, 2018

Just curious. Wouldn't it be better to fix rmul! at https://github.com/JuliaLang/julia/blob/master/stdlib/LinearAlgebra/src/dense.jl#L17? Otherwise other functions using this rmul! will still produce 0.0 for Inf*0.0.

@KristofferC KristofferC mentioned this pull request Oct 19, 2018
Merged
KristofferC pushed a commit that referenced this pull request Oct 19, 2018
@andreasnoack @KristofferC
Handle case when norm==Inf in normalize (#29691)
e37724e 
Fixes #29681

(cherry picked from commit 0ba31aa)
@andreasnoack
Copy link
Member Author

Yes, I think you are right. We should remove the fast path. Interestingly, both OpenBLAS and Apple's Accelerate have the same bug so I wondered if this was actually following BLAS (like β in GEMM), but reference BLAS doesn't have a fast path.

I'll revert this fix rmul! instead.

andreasnoack added a commit that referenced this pull request Oct 19, 2018
@andreasnoack
Revert "Handle case when norm==Inf in normalize (#29691)"
b103180 
This reverts commit 0ba31aa.
@andreasnoack andreasnoack mentioned this pull request Oct 19, 2018
Merged
andreasnoack added a commit that referenced this pull request Oct 25, 2018
@andreasnoack
Remove fast paths when scaling arrays (#29726)
534fe44 
* Revert "Handle case when norm==Inf in normalize (#29691)"

This reverts commit 0ba31aa.

* Remove fast paths when scaling arrays. Also stop using BLAS since
the Julia implementations are as fast. Clean up.
KristofferC pushed a commit that referenced this pull request Oct 29, 2018
@andreasnoack @KristofferC
Remove fast paths when scaling arrays (#29726)
1ceac52 
* Revert "Handle case when norm==Inf in normalize (#29691)"

This reverts commit 0ba31aa.

* Remove fast paths when scaling arrays. Also stop using BLAS since
the Julia implementations are as fast. Clean up.

(cherry picked from commit 534fe44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreasnoack @wsshin @fredrikekre @KristofferC