Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type assertion hack in mapreduce for skipmissing #28035

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Remove type assertion hack in mapreduce for skipmissing #28035

merged 1 commit into from
Jul 14, 2018

Conversation

nalimilan
Copy link
Member

No longer needed since #27945.

@nanosoldier runbenchmarks("union", vs=":master")

@nalimilan nalimilan added the missing data Base.missing and related functionality label Jul 10, 2018
@nalimilan nalimilan requested a review from vtjnash July 10, 2018 15:23
@nalimilan nalimilan mentioned this pull request Jul 10, 2018
Merged
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@nalimilan
Copy link
Member Author

Mmm, it doesn't look like we can get rid of it yet @vtjnash.

@vtjnash
Copy link
Member

vtjnash commented Jul 10, 2018

Hm, seemed like it fixed the reduced case. Might need to remove simd annotation too?

@vtjnash
Copy link
Member

vtjnash commented Jul 10, 2018

Probably also needs #24129. But let me know if that doesn't fix it.

@nalimilan
Copy link
Member Author

Trying again now that #24129 has been merged.

@nanosoldier runbenchmarks("union", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@nalimilan
Copy link
Member Author

Looks good now! The apparent regressions and improvements are unrelated. I'll merge in a while.

@JeffBezanson
Copy link
Member

Cool!

@nalimilan nalimilan merged commit 83ce9c7 into master Jul 14, 2018
@nalimilan nalimilan deleted the nl/cleanup branch July 14, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
missing data Base.missing and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nalimilan @nanosoldier @vtjnash @JeffBezanson