Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more compiler cleanup [nfc] #27945

Merged
merged 3 commits into from
Jul 10, 2018
Merged

more compiler cleanup [nfc] #27945

merged 3 commits into from
Jul 10, 2018

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 5, 2018

No description provided.

@vtjnash
Copy link
Member Author

vtjnash commented Jul 6, 2018

@nanosoldier runbenchmarks(ALL, vs = ":master")

@StefanKarpinski
Copy link
Member

What does "nfc" stand for? Near-field communication?

@Keno
Copy link
Member

Keno commented Jul 6, 2018

No functional changes

NULL, // cmds
NULL, // image_file (will be filled in below)
NULL, // cpu_target ("native", "core2", etc...)
0, // nprocs
NULL, // machine_file
NULL, // project
Copy link
Member

@StefanKarpinski StefanKarpinski Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! (Although it really should be in a separate PR or at least a separate commit.)

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@vtjnash
Copy link
Member Author

vtjnash commented Jul 6, 2018

I don't understand how this could have affected allocations for sumcolon_view and sumrange_view , and time for ["problem", "seismic"]

@vtjnash
Copy link
Member Author

vtjnash commented Jul 8, 2018

@nanosoldier runbenchmarks("sumcolon_view" || "sumrange_view" || "seismic", vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

vtjnash added 3 commits July 9, 2018 16:33
- dereferenceable attribute requires align attribute (if eltype is not
sized) or it is simply ignored

- tbaa_const isn't necessarily sufficient to allow LICM hoisting. an
unknown call instruction (such as julia.gc_alloc_obj) present in the
same loop can prevent TBAA from declaring the memory to be immutable.
However, the invariant.load attribute is much stronger:
additionally mark all tbaa_const loads with MD_immutable_load,
permitting llvm to reorder and left them them much more freely
(requiring only dereferenceable).
@vtjnash vtjnash force-pushed the jn/arrayvar-cleanup branch from f6bd488 to d803472 Compare July 9, 2018 20:39
@vtjnash
Copy link
Member Author

vtjnash commented Jul 10, 2018

Not precisely NFC anymore, since this uncovered optimizations that we thought were happening but weren’t, so @nanosoldier runbenchmarks(ALL, vs = ":master") with the fixes for those

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants