Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: degree trig functions on square matrices #27254

Closed
wants to merge 1 commit into from
Closed

RFC: degree trig functions on square matrices #27254

wants to merge 1 commit into from

Conversation

StefanKarpinski
Copy link
Member

No description provided.

@JeffBezanson
Copy link
Member

We could also make deg2rad and rad2deg work on any argument that supports multiplication with a scalar.

@StefanKarpinski
Copy link
Member Author

That's also a sensible idea. I'm putting this out there as an RFC: it seems to make sense to me that this function is well-defined for square matrices since it can be defined in terms of a Taylor series. If people think that makes sense I'll add tests for this behavior as well.

@StefanKarpinski StefanKarpinski changed the title degree trig functions on square matrices RFC: degree trig functions on square matrices May 24, 2018
@kshyatt kshyatt added the linear algebra Linear algebra label May 27, 2018
@StefanKarpinski StefanKarpinski mentioned this pull request Nov 24, 2018
Closed
@ronisbr
Copy link
Member

ronisbr commented Nov 28, 2018 •
edited
Loading

Is there any geometrical meaning of computing a sine/cosine of a matrix in "degrees"?

@StefanKarpinski StefanKarpinski added the help wanted Indicates that a maintainer wants help on an issue or pull request label Nov 28, 2018
@ronisbr
Copy link
Member

ronisbr commented Dec 8, 2018

@StefanKarpinski I think I can help here, but I need to understand what is to compute a degree trig function in a matrix. I am not seeing a geometrical meaning. Any idea? Just a scaling in the series expansion?

@StefanKarpinski
Copy link
Member Author

Honestly I don’t really know. I would presume the same meaning as the natural versions but with degrees in place or radians.

@ViralBShah
Copy link
Member

Thoughts on what is next here? Is it still unclear?

@StefanKarpinski
Copy link
Member Author

I'm closing this because it's annoying to have this PR hanging around open.

@StefanKarpinski StefanKarpinski mentioned this pull request Aug 12, 2019
Closed
@AtsushiSakai AtsushiSakai mentioned this pull request Feb 20, 2021
Merged
@DilumAluthge DilumAluthge deleted the sk/trig branch March 25, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StefanKarpinski @JeffBezanson @ronisbr @ViralBShah @kshyatt