Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement degree trig functions on square matrices #651

Closed
StefanKarpinski opened this issue Aug 12, 2019 · 5 comments · Fixed by JuliaLang/julia#39758
Closed

implement degree trig functions on square matrices #651

StefanKarpinski opened this issue Aug 12, 2019 · 5 comments · Fixed by JuliaLang/julia#39758
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@StefanKarpinski
Copy link
Member

See this closed PR: JuliaLang/julia#27254.
@StefanKarpinski StefanKarpinski added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 12, 2019
@pmk21
Copy link

pmk21 commented Aug 13, 2019

I'd like to work on this, I'm new to contributing here and any advice on how to solve this would be helpful.

@StefanKarpinski
Copy link
Member Author

StefanKarpinski commented Aug 14, 2019 •
edited
Loading

Welcome to the project! A possible implementation was given in the linked PR. It would need tests, NEWS and documentation updates in order to be ready to merge. There was also the possibility raised of generalizing deg2rad and rad2deg to support any kind of value that can be multiplied by a scalar, which would include arrays (and in particular matrices). I would suggest exploring that approach first and seeing how it plays out.

@pmk21 pmk21 mentioned this issue Aug 15, 2019
Closed
@simonbyrne
Copy link
Contributor

simonbyrne commented Aug 16, 2019 •
edited
Loading

Is there actually a use case for this? Or just for a sense of completeness?

Note that any solution should correctly handle sind's raison d'etre, e.g. sind(180) == 0, sind(30) == 0.5

@StefanKarpinski
Copy link
Member Author

I don't recall what the original situation for this was. I think I was trying to call some generic code on a matrix instead of a scalar and this was what failed.

@AtsushiSakai AtsushiSakai mentioned this issue Feb 20, 2021
Merged
@AtsushiSakai
Copy link

Hi. I created a PR JuliaLang/julia#39758 to fix this issue. I'm happy for someone to review it. Thanks.

@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
4 participants
@StefanKarpinski @simonbyrne @AtsushiSakai @pmk21