atan2 -> atan #27253
Merged
atan2 -> atan #27253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
approved these changes
May 24, 2018
ararslan
reviewed
May 25, 2018
base/math.jl
Outdated
| """ | ||
| atan(x::Number) | ||
| atan(x::Number) |
There was a problem hiding this comment.
Duplicate of the line above it?
|
I like it! |
|
Rebased on master. |
|
Having two ways to do this doesn't seem ideal, given that everywhere else, we have strictly gone ahead with doing things the right way. Perhaps removing |
|
I agree it is probably suboptimal to keep it around. That said, we might want to keep some sort of warning or hint around post-1.0 to aid discovery? |
|
Wouldn't people naturally look in the |
Sacha0
approved these changes
May 29, 2018
|
We could have a permanent deprecation for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27248.