Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atan2 as 2-arg method of atan #27248

Closed
simonbyrne opened this issue May 24, 2018 · 5 comments
Closed

atan2 as 2-arg method of atan #27248

simonbyrne opened this issue May 24, 2018 · 5 comments
Labels
maths Mathematical functions

Comments

@simonbyrne
Copy link
Contributor

Should atan2 become a 2-argument method of atan?

The main argument against would be convention: atan2 is well-established, going back at least to Fortran IV (1961).

The only languages I have found that do combine them are Mathematica ArcTan and Common Lisp atan.

@simonbyrne simonbyrne added the maths Mathematical functions label May 24, 2018
@StefanKarpinski
Copy link
Member

We could at least allow atan(y, x) as another way of writing atan2(y, x).

@jrevels
Copy link
Member

jrevels commented May 24, 2018

The convention is cemented enough that it has its own wikipedia entry under https://en.wikipedia.org/wiki/Atan2. The discoverability factor there might be a point in favor of keeping the current name.

@StefanKarpinski
Copy link
Member

StefanKarpinski commented May 24, 2018

I would favor keeping two-argument atan2 but also allowing atan(y, x) (non-breaking).

@jrevels
Copy link
Member

jrevels commented May 25, 2018

I'm just bikeshedding here, but I don't think the proposed change renders a benefit that outweighs the detriment of exporting multiple names for the same operation. My preference is just to keep atan2 due to convention.

@Sacha0
Copy link
Member

Sacha0 commented May 25, 2018

I'm just bikeshedding here, but I don't think the proposed change renders a benefit that outweighs the detriment of exporting multiple names for the same operation. My preference is just to keep atan2 due to convention.

I would begin arguing along the same lines as Jarrett, but instead conclude that discarding the relic of past programming languages' constraints that is atan2 is best 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maths Mathematical functions
Projects
None yet
Development

No branches or pull requests

4 participants