-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate cat(dim, Xs...)
to cat(Xs..., dims=dim)
#27163
Conversation
Man, rough go on CI: FreeBSD timed out, both Travis Linuxes got stuck/segfaulted waiting for a git username/password, and CircleCI isn't even loading for me, so I cannot see what was going on in the 32bit build there. |
32bit CI loads for me and got:
|
cat(dim, Xs...)
to cat(Xs..., dim=dim)
cat(dim, Xs...)
to cat(Xs..., dims=dim)
I think we may have to increase those timeouts for libgit2 |
Note on the merge conflict: I moved this code to util.jl (with the rest of the text-color-related code, which I did to resolve a bootstrap order thing, but it makes sense anyway). |
doc/src/manual/arrays.md
Outdated
@@ -86,8 +86,8 @@ Arrays can be constructed and also concatenated using the following functions: | |||
| Function | Description | | |||
|:---------------------- |:---------------------------------------------------- | | |||
| [`cat(k, A...)`](@ref) | concatenate input n-d arrays along the dimension `k` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cat(k, A...)](@ref) ...
it should be cat(A...; dims = k)
, isn't it?
Fixes #27100. I have also started on a bigger refactor here that will more easily allow for custom arrays to extend concatenations, but that ended up being not as simple as I had hoped, so this PR simply moves to the
dims
keyword argument and hides all internal dispatch so Base only exposes onecat
method without restrictions on its arguments for now.