Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cat to use dims keyword arguments #27100

Closed
Keno opened this issue May 14, 2018 · 1 comment
Closed

Change cat to use dims keyword arguments #27100

Keno opened this issue May 14, 2018 · 1 comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Milestone

Comments

@Keno
Copy link
Member

Keno commented May 14, 2018

It was pointed out that cat wasn't included in the recent refactor to make
dimensionality a keyword argument. cat is a bit different than the other such
functions in that it is often called with only a single dimension, but the argument does
generalize:

julia> cat(1, 2, 3, 4)
3-element Array{Int64,1}:
 2
 3
 4

julia> cat((1,2), 2, 3, 4)
3×3 Array{Int64,2}:
 2  0  0
 0  3  0
 0  0  4

Given those, examples, I think it would be nice to explicitly call out which argument is the dimension, e.g.:

cat(2, 3, 4; dims = 1)

There's a question what the default should be if no argument is passed. For now, we can't really do anything abut that because of the deprecation (so we should make calls that don't match the deprecation and don't have the keyword arg an error), but it may be nice to eventually do something automatic based on the argument types.

@Keno Keno added help wanted Indicates that a maintainer wants help on an issue or pull request triage This should be discussed on a triage call labels May 14, 2018
@JeffBezanson JeffBezanson added this to the 1.0 milestone May 17, 2018
@Keno Keno removed the triage This should be discussed on a triage call label May 17, 2018
@mbauman
Copy link
Member

mbauman commented May 17, 2018

I'm working on this — triage is in support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

No branches or pull requests

3 participants