Change cat
to use dims
keyword arguments
#27100
Labels
help wanted
Indicates that a maintainer wants help on an issue or pull request
Milestone
It was pointed out that
cat
wasn't included in the recent refactor to makedimensionality a keyword argument.
cat
is a bit different than the other suchfunctions in that it is often called with only a single dimension, but the argument does
generalize:
Given those, examples, I think it would be nice to explicitly call out which argument is the dimension, e.g.:
There's a question what the default should be if no argument is passed. For now, we can't really do anything abut that because of the deprecation (so we should make calls that don't match the deprecation and don't have the keyword arg an error), but it may be nice to eventually do something automatic based on the argument types.
The text was updated successfully, but these errors were encountered: