Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg3: the great bikeshed rename #26152

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Pkg3: the great bikeshed rename #26152

merged 1 commit into from
Feb 24, 2018

Conversation

StefanKarpinski
Copy link
Member

@StefanKarpinski StefanKarpinski commented Feb 21, 2018 •
edited
Loading

@StefanKarpinski StefanKarpinski changed the base branch from master to kc/pkg3_stdlib February 21, 2018 21:55
@StefanKarpinski StefanKarpinski mentioned this pull request Feb 21, 2018
Merged
@KristofferC
Copy link
Member

clones is much better than upstream. I wonder if it can be a bit confusing if people think that cloned packages will go into the clones directory. Technically, the packages and clones directory should never be touched, should they be .clones .packages etc?

@StefanKarpinski
Copy link
Member Author

I think people want to be able to see their installed packages so packages should not be hidden, but the source trees installed in there should be read-only. Making the clones directory hidden makes some sense but I'm disinclined from making anything in ~/.julia hidden at all – it seems better to leave everything visible and document how it works and what everything means. People may want to go into their ~/.julia/clones directory and pull from upstreams that aren't in a registry, for example.

@StefanKarpinski StefanKarpinski force-pushed the sk/pkg3bikeshed branch 2 times, most recently from 8440f42 to fc250c0 Compare February 22, 2018 20:53
@KristofferC KristofferC force-pushed the kc/pkg3_stdlib branch 5 times, most recently from d86d27e to 41ce00e Compare February 23, 2018 14:33
@StefanKarpinski StefanKarpinski changed the base branch from kc/pkg3_stdlib to master February 23, 2018 17:08
@StefanKarpinski StefanKarpinski force-pushed the sk/pkg3bikeshed branch 2 times, most recently from 4811f5c to 4e7c3ca Compare February 23, 2018 19:53
@StefanKarpinski
Copy link
Member Author

Please note that I needed to merge JuliaRegistries/General#10 in order to get this to pass tests and until this is merged Pkg3 is in a wildly broken state. I will merge this ASAP and then things will be fixed!

@KristofferC KristofferC mentioned this pull request Feb 23, 2018
Closed
@StefanKarpinski StefanKarpinski merged commit a61ed85 into master Feb 24, 2018
@StefanKarpinski StefanKarpinski deleted the sk/pkg3bikeshed branch February 24, 2018 00:45
@KristofferC KristofferC mentioned this pull request Feb 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanKarpinski @KristofferC