-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bikeshed all the things #142
Comments
Here's what my gut is telling me about names: Files in projects
Files in registries
TOML Key HierarchiesI think we should do this with dotted keys as described above. SectionsStick with lowercase Potential format for Registries.tomlregistries = [
"Personal",
"OrgPrivate",
"OrgPublic",
"Curated",
"Uncurated",
] The earlier in the list a registry appears the higher precedence it take, which only affects the meaning of a version name when there is a disagreement between the different registries. We may want to do something about combining or overriding dependencies and compatibility as well. |
Depot LayoutAnother thing to bikeshed. Currently we have:
Should these be uppercase? Other file names seem to be going that way but I like them lowercase, perhaps because they're generic locations for collections of things. We will need a few more of these directories in the future:
|
re: FileName.toml vs JuliaFileName.toml |
re: CapitalizedNames vs. lowercasednames |
etc: |
The two names exist because one may want to have a single repo which contains both Julia code and some other code and
👍
The items in the |
They are contingent dependencies. I very much like where this is headed. |
I decided to go ahead with all of this except for the |
🆗 |
Anything left to do here? |
Nah, seems good now. |
Actually, there is one thing to do: make the |
consistent abbreviation of "compat" (#142)
File Names
dependencies.toml
=>deps.toml
orDeps.toml
to match[deps]
sectionscompatibility.toml
=>compat.toml
orCompat.toml
to match theCompat.toml
file we'll have soon in project directoriespackage.toml
seems fine but if we want to capitalize thenPackage.toml
versions.toml
seems fine but if we want to capitalize thenVersions.toml
Capitalization
Since we have
Project.toml
andManifest.toml
we'll want the compatibility file to be calledCompat.toml
. Do we want the file in registries to match and be calledCompat.toml
– note that it does not have the same format as theCompat.toml
in a project directory, so maybe these should have different names entirely or maybe the capitalization difference is ok. If we do want to call the file in registriesCompat.toml
then I suppose we should capitalize the other ones as well, soDeps.toml
,Compat.toml
,Package.toml
andVersions.toml
. Perhaps capitalizing them all is better since it feels more consistent with the files in project directories. But thenDeps.toml
doesn't match[deps]
. Perhaps that's fine or maybe we want to capitalize the section name as well?TOML Key Hierarchy
Currently we have
git-tree-sha1
and that's it. However, we'll soon addarchive
/archive-url
andarchive-sha256
. We will, in the future want to have other ways of identifying source trees, including git tree hashes using whatever cryptographically secure hashing algorithm SHA-1 is replaced with and potentially other non-git source tree hashing algorithms (examples are surprisingly hard to find). So we may want to have a bit more structure to these keys. Since TOML added support for inline dotted keys, there's no syntactic cost to creating a semantic hierarchy for these keys. So, for example, we could have this kind of scheme:This way all the stuff that describes the source tree is under the
tree
key and all the stuff describing the archive – where to get it, what hashes the archive file should have before you try to unpack it – are under thearchive
key.The text was updated successfully, but these errors were encountered: