Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace a few simple, unambiguous uses of full #23815

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Sep 22, 2017

Another small step towards deprecation of full. Ref. #12153, #12251, #18850, and linked threads. Best!

@Sacha0 Sacha0 added the domain:linear algebra Linear algebra label Sep 22, 2017
@Sacha0 Sacha0 added this to the 1.0 milestone Sep 22, 2017
@andreasnoack andreasnoack merged commit 8b050e1 into JuliaLang:master Sep 22, 2017
@andreasnoack
Copy link
Member

Oops. Tridiagonal is now parametric so this is actually now unambiguous anymore. Unwrapping the Tridiagonal matrix could depend on what kind of vectors are wrapped. As discussed during the triage a month ago, the name full might not be appropriate but having a generic function for this instead of explicitly using types might be generally useful.

@Sacha0
Copy link
Member Author

Sacha0 commented Sep 22, 2017

Oops. Tridiagonal is now parametric so this is actually now unambiguous anymore. Unwrapping the Tridiagonal matrix could depend on what kind of vectors are wrapped.

Could you expand? To my knowledge, full on Tridiagonal has only ever meant convert(Array, ...)? Thanks!

@Sacha0
Copy link
Member Author

Sacha0 commented Sep 22, 2017

As discussed during the triage a month ago, the name full might not be appropriate but having a generic function for this instead of explicitly using types might be generally useful.

Yes, absolutely :). The plan I've been whittling away at is: (1) eliminate all remaining simple, unambiguous uses of full (which this pull request completes I believe); (2) eliminate all remaining not-so-simple uses of full that do not require the "lessspecial(...)" mechanism; and then (3) sketch an implementation of the "lessspecial(...)" mechanism and downstream replacements of full, then see how things look. Thoughts? Best! (Ref. #23270.)

@Sacha0 Sacha0 deleted the nixeasyfulls branch September 22, 2017 17:42
@andreasnoack
Copy link
Member

Could you expand? To my knowledge, full on Tridiagonal has only ever meant convert(Array, ...)?

I think this was an oversight when Tridiagonal was made parametric. If the vectors are distributed then the result of full should probably be a distributed matrix. I don't think anything in this PR has to change, though. At least not now.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants