Replace a few simple, unambiguous uses of full. (#23815)

JuliaLang · Sep 22, 2017 · 8b050e1 · 8b050e1
1 parent 81308aa
commit 8b050e1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/base/linalg/schur.jl b/base/linalg/schur.jl
@@ -109,7 +109,7 @@ schur(A::Symmetric) = schur(full(A))
 schur(A::Hermitian) = schur(full(A))
 schur(A::UpperTriangular) = schur(full(A))
 schur(A::LowerTriangular) = schur(full(A))
-schur(A::Tridiagonal) = schur(full(A))
+schur(A::Tridiagonal) = schur(Matrix(A))
 
 
 """

diff --git a/base/linalg/special.jl b/base/linalg/special.jl
@@ -65,7 +65,7 @@ function convert(::Type{Tridiagonal}, A::SymTridiagonal)
 end
 
 function convert(::Type{Diagonal}, A::AbstractTriangular)
-    if full(A) != diagm(diag(A))
+    if !isdiag(A)
         throw(ArgumentError("matrix cannot be represented as Diagonal"))
     end
     Diagonal(diag(A))

diff --git a/base/linalg/triangular.jl b/base/linalg/triangular.jl
@@ -1434,7 +1434,7 @@ end
 ## for these cases, but I'm not sure it is worth it.
 for t in (UpperTriangular, UnitUpperTriangular, LowerTriangular, UnitLowerTriangular)
     @eval begin
-        (*)(A::Tridiagonal, B::$t) = A_mul_B!(full(A), B)
+        (*)(A::Tridiagonal, B::$t) = A_mul_B!(Matrix(A), B)
     end
 end