getaddrinfo, getnameinfo #23596
Merged
getaddrinfo, getnameinfo #23596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
Sep 6, 2017
| req = Libc.malloc(_sizeof_uv_getaddrinfo) | ||
| uv_req_set_data(req, C_NULL) # in case we get interrupted before arriving at the wait call | ||
| status = ccall(:jl_getaddrinfo, Int32, (Ptr{Void}, Ptr{Void}, Cstring, Ptr{Void}, Ptr{Void}), | ||
| eventloop(), req, host, #=service=#C_NULL, uv_jl_getaddrinfocb::Ptr{Void}) |
There was a problem hiding this comment.
Probably meant to take out #=service=#
There was a problem hiding this comment.
No, I like doing comments of his form
quinnj
reviewed
Sep 6, 2017
| if status < 0 | ||
| Libc.free(req) | ||
| if status == UV_EINVAL | ||
| throw(ArgumentError("Invalid getaddrinfo argument")) |
There was a problem hiding this comment.
probably should update all these error messages to reference getalladdrinfo instead of getaddrinfo (though I'm not a huge fan of the getalladdrinfo name).
There was a problem hiding this comment.
The error itself still comes from getaddrinfo
|
I approve of the deprecation part. |
vtjnash
force-pushed
the
jn/21555
branch
2 times, most recently
from
1915931
to
45dd908
Compare
|
Looks like CI hit a lot of known bad tests, but is otherwise passing |
vtjnash
force-pushed
the
jn/21555
branch
4 times, most recently
from
1e10468
to
63503a3
Compare
expose more system functionality, add getalladdrinfo to get a list of all address (rather than just the first) avoid making callbacks from inside the libuv event loop fix #21555
This function is the complement of getaddinfo.
This was referenced Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves API coverage of basic socket infrastructure.