RFC: Activate IPv6 getaddrinfo, and return all addresses #10335
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9892
before:
after:
This is the opposite of my suggestion last night. But, after some reading, I believe this is the expected behavior of this function on both POSIX and Windows. This would be a breaking change for functions that rely on the current behavior of
connect!
, which is to take whatever address the system provides first. I'm punting on changing all of that until I get some opinions on whether it is worth fixing the API now to fully support IPv6, or continuing to put it off until someone actually needs it. @vtjnash had some concerns about OS inconsistencies last night on IRC.Could just do the minimum to fix the broken test in #9892 instead.
@vtjnash @amitmurthy @Keno