-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove .jl extension in Pkg.update #23214
Conversation
Added a test, it's a simple one, but at least it test that it does not error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fredrikekre! :)
Travis increased our timeout by half an hour, and gave us 50% more capacity for a week. But apparently the tests on 32 bit linux are so slow that we need all of that time and this came very close to timing out there. |
* remove .jl extension in Pkg.update * add test (cherry picked from commit 4c5cc04)
* remove .jl extension in Pkg.update * add test (cherry picked from commit 4c5cc04)
* remove .jl extension in Pkg.update * add test (cherry picked from commit 4c5cc04)
* remove .jl extension in Pkg.update * add test (cherry picked from commit 4c5cc04)
* remove .jl extension in Pkg.update * add test (cherry picked from commit 4c5cc04)
Missed this in #20681, fix #23212