Skip to content

Commit

Permalink
remove .jl extension in Pkg.update (#23214)
Browse files Browse the repository at this point in the history
* remove .jl extension in Pkg.update

* add test
  • Loading branch information
fredrikekre authored Aug 12, 2017
1 parent 143c9e2 commit 4c5cc04
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion base/pkg/pkg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ optimal set of packages versions.
Without arguments, updates all installed packages. When one or more package names are provided as
arguments, only those packages and their dependencies are updated.
"""
update(upkgs::AbstractString...) = cd(Entry.update,Dir.getmetabranch(),Set{String}([upkgs...]))
update(upkgs::AbstractString...) = cd(Entry.update,Dir.getmetabranch(),Set{String}(splitjl.([upkgs...])))

"""
resolve()
Expand Down
1 change: 1 addition & 0 deletions test/pkg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,7 @@ end
Pkg.add("Example.jl")
@test [keys(Pkg.installed())...] == ["Example"]
iob = IOBuffer()
Pkg.update("Example.jl")
Pkg.checkout("Example.jl")
Pkg.status("Example.jl", iob)
str = chomp(String(take!(iob)))
Expand Down

8 comments on commit 4c5cc04

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@ararslan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, that's weird. Why did Nanosoldier do another daily run on something merged earlier that already had a daily run? @jrevels

@fredrikekre
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing new was merged for a day.

@ararslan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I can't remember the last time I've seen that happen!

@jrevels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ararslan In case you're curious, here is Nanosoldier's daily job submission script (it runs as a daily cronjob).

Please sign in to comment.