Build fixes for ASAN #21902
Merged
Build fixes for ASAN #21902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DEPS_CFLAGS was added by Keno in #10785. It's possible someone may have been setting it in Make.user or on the make command line, possibly for non sanitizer related purposes, in which case I don't think we need to remove them from a release branch but on master should be okay. |
tkelman
reviewed
May 16, 2017
deps/tools/common.mk
Outdated
| CMAKE_CC_ARG := $(CC_ARG) $(DEPS_CFLAGS) | ||
| CMAKE_CXX_ARG := $(CXX_ARG) $(DEPS_CXXFLAGS) | ||
| CMAKE_CC_ARG := $(CC_ARG) | ||
| CMAKE_CXX_ARG := $(CXX_ARG) $ |
Sounds reasonable. Do I create a second PR for backporting the core fix, or just leave it as-is? |
|
I can get that commit in a backport batch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDFLAGSgot erroneously populated with-fsanitize=address, causing in my case openspecfun to get linked against an incompatible ASAN runtime (because of usinggfortraninstead ofclang).I also removed traces of
DEPS_C*FLAGS, which was only used for the (defunct) building of deps+ASAN.CI failure before (
Your application is linked against incompatible ASan runtimes.), after (still fails, but due to different issues).