Skip to content

Commit

Permalink
Only populate Julia-specific LDFLAGS with ASAN options.
Browse files Browse the repository at this point in the history 
(cherry picked from commit 1db6e10)
ref #21902
  • Loading branch information
@maleadt @tkelman
maleadt authored and tkelman committed May 17, 2017
1 parent 09d3b26 commit a9d418e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Make.inc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ SANITIZE_LDFLAGS := -fsanitize=address
endif
JCXXFLAGS += $(SANITIZE_OPTS)
JCFLAGS += $(SANITIZE_OPTS)
LDFLAGS += $(SANITIZE_LDFLAGS)
JLDFLAGS += $(SANITIZE_LDFLAGS)
# FIXME: sanitizing all dependencies doesn't work because of -Wl,--no-undefined
# https://github.com/JuliaLang/julia/issues/13858
# use LLVM_SANITIZE to sanitize LLVM
Expand Down

2 comments on commit a9d418e

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks("parse", vs = "@6bdb3950bdf64152")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @jrevels

Please sign in to comment.