Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on deprecation warnings for type and immutable #21777

Merged
merged 2 commits into from
May 17, 2017

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added the deprecation This change introduces or involves a deprecation label May 10, 2017
@JeffBezanson JeffBezanson force-pushed the jb/deprecate_type_reswords branch from 20933e1 to c1183ac Compare May 10, 2017 19:20
@tkelman
Copy link
Contributor

tkelman commented May 10, 2017

should probably backport the doc and test bits of this, obviously not the deprecation itself though

@JeffBezanson JeffBezanson force-pushed the jb/deprecate_type_reswords branch from c1183ac to 726b243 Compare May 10, 2017 20:49
@JeffBezanson
Copy link
Member Author

Commit split for that purpose.

@tkelman tkelman force-pushed the jb/deprecate_type_reswords branch from 726b243 to 3884fdc Compare May 13, 2017 10:42
@tkelman
Copy link
Contributor

tkelman commented May 13, 2017

there was one more under examples that I fixed for you, squashed into the first commit

(backport pending only for that commit)

@tkelman tkelman added backport pending 0.6 needs news A NEWS entry is required for this change labels May 13, 2017
tkelman pushed a commit that referenced this pull request May 14, 2017
@JeffBezanson JeffBezanson force-pushed the jb/deprecate_type_reswords branch from 3884fdc to 9a8adb5 Compare May 16, 2017 17:46
@JeffBezanson JeffBezanson removed the needs news A NEWS entry is required for this change label May 16, 2017
@JeffBezanson JeffBezanson merged commit 7d77244 into master May 17, 2017
@JeffBezanson JeffBezanson deleted the jb/deprecate_type_reswords branch May 17, 2017 03:29
@KristofferC
Copy link
Member

FWIW I updated https://gist.github.com/KristofferC/24c269727d914ffb88bfc21624dad891.

Run update_folder!(folder::String) to see what files that would be edited and then update_folder!(folder, false) to actually do the replacements. I did
KristofferC/NearestNeighbors.jl#46 and KristofferC/Crayons.jl#10 with the script.

@ararslan
Copy link
Member

I probably would have waited until there's a 0.6 release so that packages can soundly require 0.6 without having to worry about 0.6-, which can include 0.6-dev pre-struct. ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants