Merge pull request #21777 from JuliaLang/jb/deprecate_type_reswords

turn on deprecation warnings for `type` and `immutable`

NEWS.md

@@ -32,6 +32,9 @@ Compiler/Runtime improvements
 Deprecated or removed
 ---------------------
 
+  * The keyword `immutable` is fully deprecated to `struct`, and
+    `type` is fully deprecated to `mutable struct` ([#19157], [#20418]).
+
   * The method `srand(rng, filename, n=4)` has been deprecated ([#21359]).
 
 

base/reflection.jl

@@ -340,7 +340,7 @@ fieldoffset(x::DataType, idx::Integer) = (@_pure_meta; ccall(:jl_get_field_offse
 Determine the declared type of a field (specified by name or index) in a composite DataType `T`.
 
 ```jldoctest
-julia> immutable Foo
+julia> struct Foo
            x::Int64
            y::String
        end
@@ -361,7 +361,7 @@ Get the index of a named field, throwing an error if the field does not exist (w
 or returning 0 (when err==false).
 
 ```jldoctest
-julia> immutable Foo
+julia> struct Foo
            x::Int64
            y::String
        end

doc/src/manual/modules.md

@@ -21,7 +21,7 @@ importall OtherLib
 
 export MyType, foo
 
-type MyType
+struct MyType
     x
 end
 

examples/queens.jl

@@ -2,7 +2,7 @@
 
 # n-queens (nqueens) solver, for nsquaresx-by-nsquaresy board
 
-immutable Queen
+struct Queen
     x::Int
     y::Int
 end

src/julia-parser.scm

@@ -1331,11 +1331,10 @@
                              (expect-end (take-lineendings s) "primitive type"))))))
        ;; deprecated type keywords
        ((type)
-        ;; TODO fully deprecate post-0.6
-        ;;(syntax-deprecation s "type" "mutable struct")
+        (syntax-deprecation s "type" "mutable struct")  ;; retain in 0.7
         (parse-struct-def s #t word))
        ((immutable)
-        ;;(syntax-deprecation s "immutable" "struct")
+        (syntax-deprecation s "immutable" "struct")  ;; retain in 0.7
         (parse-struct-def s #f word))
        ((bitstype)
         (let* ((nb   (with-space-sensitive (parse-cond s)))

test/core.jl

@@ -4896,7 +4896,7 @@ foo21568()
 @test f21568([0]) == 1
 
 # issue #21719
-type T21719{V}
+mutable struct T21719{V}
     f
     tol::Float64
     goal::V

test/inference.jl

@@ -740,7 +740,7 @@ let e = code_typed(f21175, ())[1].first.code[1]::Expr
 end
 
 # issue #10207
-type T10207{A, B}
+mutable struct T10207{A, B}
     a::A
     b::B
 end

test/sparse/sparsevector.jl

@@ -1124,7 +1124,7 @@ end
 @test issparse([sprand(10,.1); rand(10)])
 
 
-type t20488 end
+mutable struct t20488 end
 
 @testset "similar" begin
     x = sparsevec(rand(3) .+ 0.1)

test/subtype.jl

@@ -1102,7 +1102,7 @@ end
 
 # issue #21613
 abstract type A21613{S <: Tuple} end
-immutable B21613{S <: Tuple, L} <: A21613{S}
+struct B21613{S <: Tuple, L} <: A21613{S}
     data::NTuple{L,Float64}
 end
 @testintersect(Tuple{Type{B21613{Tuple{L},L}} where L, Any},