converted sparse/umfpack to testsets #20956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Mar 9, 2017
test/sparse/umfpack.jl
Outdated
| #4523 - complex sparse \ | ||
| x = speye(2) + im * speye(2) | ||
| @test (x*(lufact(x) \ ones(2))) ≈ ones(2) | ||
| @testset "issue #4523 complex sparse" begin |
ararslan
added
linear algebra
tkelman
reviewed
Mar 9, 2017
test/sparse/umfpack.jl
Outdated
| @test A_ldiv_B!(copy(X), luA, B) ≈ A_ldiv_B!(copy(X), lufA, B) | ||
| @test At_ldiv_B!(copy(X), luA, B) ≈ At_ldiv_B!(copy(X), lufA, B) | ||
| @test Ac_ldiv_B!(copy(X), luA, B) ≈ Ac_ldiv_B!(copy(X), lufA, B) | ||
| @testset "# Test that A[c|t]_ldiv_B!{T<:Complex}(X::StridedMatrix{T}, lu::UmfpackLU{Float64}, # B::StridedMatrix{T}) works as expected." begin |
There was a problem hiding this comment.
remove the # characters from the description string
tkelman
reviewed
Mar 9, 2017
test/sparse/umfpack.jl
Outdated
| @test A_ldiv_B!(copy(X), luA, B) ≈ A_ldiv_B!(copy(X), lufA, B) | ||
| @test At_ldiv_B!(copy(X), luA, B) ≈ At_ldiv_B!(copy(X), lufA, B) | ||
| @test Ac_ldiv_B!(copy(X), luA, B) ≈ Ac_ldiv_B!(copy(X), lufA, B) | ||
| @testset "# Test that A[c|t]_ldiv_B!{T<:Complex}(X::StridedMatrix{T}, lu::UmfpackLU{Float64}, # B::StridedMatrix{T}) works as expected." begin |
There was a problem hiding this comment.
remove the # characters from the description string
There was a problem hiding this comment.
there are 2 of them and you only got rid of one
There was a problem hiding this comment.
I also do not see a second one – there are some testset strings with "issue #123" in them, but that's fine.
There was a problem hiding this comment.
lu::UmfpackLU{Float64}, # B::StridedMatrix{T})
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing #18801
For the test set labeled very generically umfpack tests, I believe these were the tests added by @andreasnoack here that began test file. I wasn't sure what to name these as they are unfamiliar to me and the first big chunk seems pretty generic, so if anyone has any suggestions for naming I would gladly change.