Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test sets to sparse test code #18801

Closed
kshyatt opened this issue Oct 5, 2016 · 6 comments
Closed

Add test sets to sparse test code #18801

kshyatt opened this issue Oct 5, 2016 · 6 comments
Labels
good first issue Indicates a good issue for first-time contributors to Julia Hacktoberfest Good for Hacktoberfest participants sparse Sparse arrays test This change adds or pertains to unit tests testsystem The unit testing framework and Test stdlib

Comments

@kshyatt
Copy link
Contributor

kshyatt commented Oct 5, 2016

Now that we can use @testset everywhere, it would be nice to use it in these very long files where we have comments. This way we can remove debug flags and similar. If you need help, ask me or @Sacha0 or @andreasnoack.
@kshyatt kshyatt added test This change adds or pertains to unit tests sparse Sparse arrays testsystem The unit testing framework and Test stdlib Hacktoberfest Good for Hacktoberfest participants good first issue Indicates a good issue for first-time contributors to Julia labels Oct 5, 2016
@ssonal ssonal mentioned this issue Oct 6, 2016
Closed
@lbollar
Copy link
Contributor

lbollar commented Oct 7, 2016

I am working on a commit for this.

@lbollar lbollar mentioned this issue Oct 8, 2016
Closed
@lbollar lbollar mentioned this issue Dec 12, 2016
Merged
@pkofod
Copy link
Contributor

pkofod commented Jan 14, 2017

I believe this is fixed?

@Sacha0
Copy link
Member

Sacha0 commented Jan 14, 2017

Only test/sparse/sparse.jl and test/sparse/higherorderfns.jl use testsets at this time (leaving test/sparse/(sparsevector|spqr|cholmod|umfpack).jl in need of attention). Best!

@pkofod
Copy link
Contributor

pkofod commented Jan 14, 2017

Oh, I see you're right... Maybe it's time to get back into the test folder... Will see if I can find time to do some of them this week.

@kshyatt
Copy link
Contributor Author

kshyatt commented Jan 14, 2017

It's always a good time to get back into the test folder 😉 .

@pkofod
Copy link
Contributor

pkofod commented Jan 14, 2017

It's always a good time to get back into the test folder 😉 .

Feels like home, although I can see you've made quite a few changes around test town!

@lbollar lbollar mentioned this issue Mar 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors to Julia Hacktoberfest Good for Hacktoberfest participants sparse Sparse arrays test This change adds or pertains to unit tests testsystem The unit testing framework and Test stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ViralBShah @kshyatt @Sacha0 @lbollar @pkofod