Deprecate vectorized mod methods in favor of compact broadcast syntax #18593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
maths
|
Rebased. Best! |
tkelman
reviewed
Dec 23, 2016
| @@ -1003,6 +1003,7 @@ macro vectorize_2arg(S,f) | |||
| end | |||
| export @vectorize_1arg, @vectorize_2arg | |||
|
|
|||
| <<<<<<< HEAD | |||
|
Subsumed by #19791. |
Can you remember what those were? |
Checked local branch. No comments appear, so chances are those questions were resolved and removed. I imagine those questions concerned whether to remove certain methods for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates (almost) all remaining vectorized
modmethods (less those for SparseVectors and one related to dates, separate PRs) in favor of compact broadcast syntax. Ref. #16285, #17302, #18495, #18512, #18513, #18558, #18564, #18566, #18571 #18575, #18576, #18586, and #18590. Best!Edit: Added a couple questions for reviewers via comments in the code.
(Unlike with
float,real, etc., the remaining vectorizedmodmethods never alias their input. This PR should be less controversial than #18495, #18512, and #18513 as a result.)