-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate vectorized ceil methods in favor of compact broadcast syntax #18586
Conversation
8392f90
to
d1d8add
Compare
Travis x64 linux failure seemingly unrelated? |
Rebased. Best! |
do we now have these structured xdiagonal types returning sparse for general broadcast functions that aren't special cased? |
Not yet, no. I have not been prioritizing that change given discussion in #18590. Thoughts? Thanks! |
it's what the general sparse types do, right? how hard would it be to plug a few of the structured types into the same mechanism? otherwise will they return dense if you put them through a fused zero-preserving operation? there's a workaround of explicitly converting to sparse, but if there are operations where that's always a better thing to do then return dense, seems we might want to make it automatic |
Achieving that behavior (if inefficiently, by promoting structured arguments to sparse equivalents prior to |
agreed, material for a separate PR |
Subsumed by #19791. |
This PR deprecates all remaining vectorized
ceil
methods (less those for SparseVectors, separate PR) in favor of compact broadcast syntax. Ref. #16285, #17302, #18495, #18512, #18513, #18558, #18564, #18566, #18571 #18575, and #18576. Best!(Unlike with
float
,real
, etc., the remaining vectorizedceil
methods never alias their input. This PR should be less controversial than #18495, #18512, and #18513 as a result.)