Remove 0.4 deprecations #16605
Merged
Remove 0.4 deprecations #16605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So these will now give MethodError for non boolean input
not including the deprecated syntax in the parser, ref #13054 which could be rebased
remove a blank line at the beginning of a function
after the "0.5 deprecations" comment was added but before the final tag
|
Any objections to doing this now? We haven't quite hit feature freeze but we're getting close. Someone who's written in scheme more recently than 2003 should clean up the parser deprecations that were introduced for 0.4. |
|
Should be fun to watch PkgEval! |
|
Good thing we have that running on a nightly cron job then 😉 |
|
Surprising number of packages still using edit: DataArrays looks like the most common cause, interestingly it is referring to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not including the deprecated syntax in the parser, ref parts of #13054 which could be rebased