Workaround incorrect Uint deprecation message #13227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Uint deprecation warning suggested a system dependent type (UInt64 or UInt32) rather than UInt, due to this being a type alias. Hardcode a warning message for this rather common type, pending a more powerful deprecation warning system.
|
Yes, exactly the kind of disgustingness I had in mind :) |
|
A searchable keyword and a mention in a comment here to |
|
Sure I can add an extra note if you like, but I figured that any real solution to this problem would involve touching |
|
@ivarne - reminder added for the case that the Uint deprecation goes away before the deprecation system itself gets another look. |
JeffBezanson
added a commit
that referenced
this pull request
Sep 23, 2015
Workaround incorrect Uint deprecation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Uint deprecation warning suggested a system dependent type (UInt64 or UInt32) rather than UInt, due to this being a type alias. Hardcode a warning message for this rather common type, pending a more powerful deprecation warning system.
See #13221. I hope this is what Jeff had in mind as a quick patch for 0.4... it's pretty disgusting :-)
Fixes #13221