Fixes for julia_version. Expand and consolidate julia_version tests. #4151

IanButterworth · 2025-02-09T20:16:36Z

Trying to clear the block for BinaryBuilder updating to a recent julia version.

Expands HistoricalStdlibVersions tests based on needs outlined in Future Pkg compatibility JuliaPackaging/JLLPrefixes.jl#6 thanks to the tests constructed by @mkitti here
Stops installing HistoricalStdlibVersions manually if not installed, so any such tests would not be run via Base.runtests. It's been a pain to manage the manual install for with the latest version, so just test it on Pkg repo CI
Consolidate all julia_version tests into a single file to easier maintenance
Teaches fixups_from_projectfile! to use STDLIBS_BY_VERSION
BinaryBuilderBase.jl tests pass locally Fixes for julia_version. Expand and consolidate julia_version tests. #4151 (comment)

Fixes a few issues

libcxxwrap_julia_jll: Error During Test at /Users/runner/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:225
  Got exception outside of a @test
  MethodError: no method matching abspath(::Nothing)
  The function `abspath` exists, but no method is defined for this combination of argument types.
  
  Closest candidates are:
    abspath(::String)
     @ Base path.jl:448
    abspath(::AbstractString)
     @ Base path.jl:614
    abspath(::AbstractString, AbstractString...)
     @ Base path.jl:468
  
  Stacktrace:
    [1] fixups_from_projectfile!(env::Pkg.Types.EnvCache)
      @ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:229
    [2] add(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}, new_git::Set{Base.UUID}; allow_autoprecomp::Bool, preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform, target::Symbol)
      @ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:1661
    [3] add
      @ ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:1631 [inlined]
    [4] add(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform, target::Symbol, allow_autoprecomp::Bool, kwargs::@Kwargs{julia_version::VersionNumber, io::IOStream})
      @ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:317
    [5] add(pkgs::Vector{Pkg.Types.PackageSpec}; io::IOStream, kwargs::@Kwargs{julia_version::VersionNumber})
      @ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:164
    [6] add
      @ ~/work/Pkg.jl/Pkg.jl/src/API.jl:151 [inlined]
    [7] add(; name::String, uuid::Nothing, version::Nothing, url::Nothing, rev::Nothing, path::Nothing, mode::Pkg.Types.PackageMode, subdir::Nothing, kwargs::@Kwargs{julia_version::VersionNumber})
      @ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:181
    [8] add
      @ ~/work/Pkg.jl/Pkg.jl/src/API.jl:170 [inlined]
    [9] macro expansion
      @ ~/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:228 [inlined]

GMP_jll: Test Failed at /Users/runner/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:242
  Expression: ((Pkg.dependencies())[GMP_jll_UUID]).version === v"6.2.1+6"
   Evaluated: v"6.3.0+2" === v"6.2.1+6"
Stacktrace:
 [1] macro expansion
   @ ~/hostedtoolcache/julia/nightly/aarch64/share/julia/stdlib/v1.13/Test/src/Test.jl:679 [inlined]
 [2] macro expansion
   @ ~/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:242 [inlined]
 [3] macro expansion
   @ ~/hostedtoolcache/julia/nightly/aarch64/share/julia/stdlib/v1.13/Test/src/Test.jl:1771 [inlined]
 [4] macro expansion
   @ ~/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:241 [inlined]
 [5] macro expansion
   @ ~/hostedtoolcache/julia/nightly/aarch64/share/julia/stdlib/v1.13/Test/src/Test.jl:1771 [inlined]
 [6] (::Main.PkgTestsOuter.PkgTestsInner.HistoricalStdlibVersionsTests.var"#19#20")()
   @ Main.PkgTestsOuter.PkgTestsInner.HistoricalStdlibVersionsTests ~/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:206

GMP_jll: Error During Test at /Users/runner/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:239
  Got exception outside of a @test
  MethodError: no method matching abspath(::Nothing)
  The function `abspath` exists, but no method is defined for this combination of argument types.
  
  Closest candidates are:
    abspath(::String)
     @ Base path.jl:448
    abspath(::AbstractString)
     @ Base path.jl:614
    abspath(::AbstractString, AbstractString...)
     @ Base path.jl:468
  
  Stacktrace:
    [1] fixups_from_projectfile!(env::Pkg.Types.EnvCache)
      @ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:229
    [2] add(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}, new_git::Set{Base.UUID}; allow_autoprecomp::Bool, preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform, target::Symbol)
      @ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:1661
    [3] add
      @ ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:1631 [inlined]
    [4] add(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform, target::Symbol, allow_autoprecomp::Bool, kwargs::@Kwargs{julia_version::VersionNumber, io::IOStream})
      @ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:317
    [5] add(pkgs::Vector{Pkg.Types.PackageSpec}; io::IOStream, kwargs::@Kwargs{julia_version::VersionNumber})
      @ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:164
    [6] add
      @ ~/work/Pkg.jl/Pkg.jl/src/API.jl:151 [inlined]
    [7] add(; name::String, uuid::Nothing, version::Nothing, url::Nothing, rev::Nothing, path::Nothing, mode::Pkg.Types.PackageMode, subdir::Nothing, kwargs::@Kwargs{julia_version::VersionNumber})
      @ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:181
    [8] add
      @ ~/work/Pkg.jl/Pkg.jl/src/API.jl:170 [inlined]
    [9] macro expansion
      @ ~/work/Pkg.jl/Pkg.jl/test/historical_stdlib_version.jl:245 [inlined]

from JuliaPackaging/JLLPrefixes.jl#6 (comment) Co-Authored-By: Mosè Giordano <[email protected]> Co-Authored-By: Elliot Saba <[email protected]> Co-Authored-By: Mark Kittisopikul <[email protected]>

IanButterworth · 2025-02-11T05:09:23Z

test/historical_stdlib_version.jl

+libcxxwrap_julia_jll_UUID = Base.UUID("3eaa8342-bff7-56a5-9981-c04077f7cee7")
+libblastrampoline_jll_UUID = Base.UUID("8e850b90-86db-534c-a0d3-1478176c7d93")
+
+isolate(loaded_depot=true) do


Tests below this are new

KristofferC · 2025-02-11T13:40:22Z

What's the status of using BB together with this and a new julia version?

IanButterworth · 2025-02-11T13:50:06Z

Untested. @giordano do BB test run locally?

giordano · 2025-02-11T13:58:16Z

Can't do it right now, but relevant tests are in https://github.com/JuliaPackaging/BinaryBuilderBase.jl, in particular the test/dependencies.jl file. That's (mostly) working up to Julia v1.10.

I'm happy to make adjustments in BBB if necessary, as long as there's some guarantee we have something stable to rely on (and tests in this PR should help).

IanButterworth · 2025-02-11T19:36:12Z

@giordano @staticfloat I've requested review mainly for the stuff in test/historical_stdlib_version.jl.

giordano · 2025-02-11T20:32:44Z

The fact that tests pass is very promising (they stopped passing at some point and I lost the energy to follow Pkg changes back then), but there are some things that I'm not sure are covered by BBB tests:

Pkg.add([PackageSpec("GMP_jll")]; julia_version=v"1.6") doesn't install anything #2930: this was the reason why we never had BinaryBuilder fully working on v1.8+
Pkg.add(Pkg.Types.Context(;julia_version), [PackageSpec(...)]) failing since Julia v1.7 #2942: this was already broken in v1.7, but people have been working around it with some nasty hacking of Pkg.Types.get_last_stdlibs
Pkg.add doesn't install the requested version of JLL stdlib #3113
Unable to install unregistered package in Julia >=1.7 (when providing a Context) #3251 is the reason why https://docs.binarybuilder.org/stable/FAQ/#Can-I-publish-a-JLL-package-locally-without-going-through-Yggdrasil?-1 doesn't work (people have been asking about this in Slack every other week)

I'm just skimming through the binarybuilder label here.

giordano · 2025-02-11T20:42:34Z

Pkg.add([PackageSpec("GMP_jll")]; julia_version=v"1.6") doesn't install anything #2930: this was the reason why we never had BinaryBuilder fully working on v1.8+

I need to look at it better, but this issue may have been solved by HistoricalStdlibVersions (which came several months afterwards after that ticket was opened), and it's good this PR adds more tests about it.

IanButterworth · 2025-02-11T20:59:10Z

src/Operations.jl

+            # pkg.exts = p.exts # TODO: STDLIBS_BY_VERSION doesn't record this
+            # pkg.entryfile = p.entryfile # TODO: STDLIBS_BY_VERSION doesn't record this


Opened an issue JuliaPackaging/HistoricalStdlibVersions.jl#32

IanButterworth · 2025-02-11T23:00:04Z

test/historical_stdlib_version.jl

+            @test isdir(src)
+            @test isfile(joinpath(src, "Artifacts.toml"))


These are both failing, so #2930 remains an issue

IanButterworth · 2025-02-12T21:32:25Z

I've marked the #2930 broken tests as such. I'm proposing to merge this as is and I will continue to look into fixing #2930

staticfloat

This is great, thank you for taking this on, Ian!

giordano

🚀

…4151) (cherry picked from commit 0333d55)

… tests. (#4151)" This reverts commit fe3714e.

… tests. (#4151)" (#4255) Co-authored-by: KristofferC <[email protected]> Fixes for julia_version. Expand and consolidate julia_version tests. (#4151)"

…4151) (cherry picked from commit 0333d55)

IanButterworth changed the title ~~Expand HistoricalStdlibVersions tests~~ Expand and consolidate HistoricalStdlibVersions tests Feb 10, 2025

IanButterworth force-pushed the ib/more_hsv_tests branch 3 times, most recently from 627aea8 to 775f3a1 Compare February 10, 2025 04:25

IanButterworth and others added 3 commits February 10, 2025 20:11

don't install HSV manually

97cae6e

add HistoricalStdlibVersions tests

9612305

from JuliaPackaging/JLLPrefixes.jl#6 (comment) Co-Authored-By: Mosè Giordano <[email protected]> Co-Authored-By: Elliot Saba <[email protected]> Co-Authored-By: Mark Kittisopikul <[email protected]>

consolidate all julia_version (HistoricalStdlibVersions) tests

c64e2b8

IanButterworth force-pushed the ib/more_hsv_tests branch from 775f3a1 to c64e2b8 Compare February 11, 2025 01:11

IanButterworth added 6 commits February 10, 2025 20:34

make error more informative

b11d19e

fix version check

1a84068

rename testsets

648a02d

use temp envs for each test

74ef757

make fixups_from_projectfile! work with STDLIBS_BY_VERSION if needed

0919cbd

tweak tests

533a3c8

IanButterworth changed the title ~~Expand and consolidate HistoricalStdlibVersions tests~~ Fixes for julia_version. Expand and consolidate julia_version tests. Feb 11, 2025

workaround Pkg.dependencies() mbedtls_jll bug

109770e

IanButterworth marked this pull request as ready for review February 11, 2025 05:06

IanButterworth commented Feb 11, 2025

View reviewed changes

IanButterworth mentioned this pull request Feb 11, 2025

Future Pkg compatibility JuliaPackaging/JLLPrefixes.jl#6

Open

This comment was marked as resolved.

Sign in to view

IanButterworth requested review from giordano and staticfloat February 11, 2025 19:35

IanButterworth commented Feb 11, 2025

View reviewed changes

IanButterworth force-pushed the ib/more_hsv_tests branch from 877eb14 to 339adc5 Compare February 11, 2025 21:38

test that GMP_jll source is installed

04e48fd

IanButterworth force-pushed the ib/more_hsv_tests branch from 339adc5 to 04e48fd Compare February 11, 2025 22:34

giordano added the binarybuilder Related to the use of Pkg in BinaryBuilder label Feb 11, 2025

IanButterworth commented Feb 11, 2025

View reviewed changes

mark tests as broken

f402910

staticfloat approved these changes Feb 13, 2025

View reviewed changes

giordano approved these changes Feb 13, 2025

View reviewed changes

IanButterworth merged commit 0333d55 into JuliaLang:master Feb 13, 2025
8 of 9 checks passed

IanButterworth mentioned this pull request Feb 16, 2025

Rename context API methods as internal functions #4161

Open

IanButterworth added backport 1.10 backport 1.12 labels Feb 25, 2025

ket395 mentioned this pull request Mar 6, 2025

Patch 1 JuliaLang/juliaup#1178

Closed

KristofferC pushed a commit that referenced this pull request Mar 31, 2025

Fixes for julia_version. Expand and consolidate julia_version tests. (#…

fe3714e

…4151) (cherry picked from commit 0333d55)

KristofferC mentioned this pull request Mar 31, 2025

Backports release 1.12 #4203

Merged

7 tasks

KristofferC removed the backport 1.12 label Mar 31, 2025

KristofferC mentioned this pull request Mar 31, 2025

Backports release 1.10 #4205

Merged

7 tasks

KristofferC pushed a commit that referenced this pull request Jun 11, 2025

Revert "Fixes for julia_version. Expand and consolidate julia_version…

c1857a8

… tests. (#4151)" This reverts commit fe3714e.

KristofferC pushed a commit that referenced this pull request Jun 11, 2025

Revert "Fixes for julia_version. Expand and consolidate julia_version…

01a3342

… tests. (#4151)" This reverts commit fe3714e.

This was referenced Jun 11, 2025

Revert "Fixes for julia_version. Expand and consolidate julia_version tests. (#4151)" #4255

Merged

debug bumping 1.12 Pkg JuliaLang/julia#58675

Closed

IanButterworth added the backport 1.12 label Jun 21, 2025

IanButterworth added a commit that referenced this pull request Jun 21, 2025

Fixes for julia_version. Expand and consolidate julia_version tests. (#…

96b6a67

…4151) (cherry picked from commit 0333d55)

IanButterworth mentioned this pull request Jun 21, 2025

[release-1.12] 1.12 backports #4265

Merged

10 tasks

KristofferC removed the backport 1.12 label Jul 1, 2025

		# pkg.exts = p.exts # TODO: STDLIBS_BY_VERSION doesn't record this
		# pkg.entryfile = p.entryfile # TODO: STDLIBS_BY_VERSION doesn't record this

		@test isdir(src)
		@test isfile(joinpath(src, "Artifacts.toml"))

Uh oh!

Fixes for julia_version. Expand and consolidate julia_version tests. #4151

Fixes for julia_version. Expand and consolidate julia_version tests. #4151

Uh oh!

Conversation

IanButterworth commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IanButterworth Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

KristofferC commented Feb 11, 2025

Uh oh!

IanButterworth commented Feb 11, 2025

Uh oh!

giordano commented Feb 11, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

IanButterworth commented Feb 11, 2025

Uh oh!

giordano commented Feb 11, 2025

Uh oh!

giordano commented Feb 11, 2025

Uh oh!

IanButterworth Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

IanButterworth Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

IanButterworth commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staticfloat left a comment

Choose a reason for hiding this comment

Uh oh!

giordano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

IanButterworth commented Feb 9, 2025 •

edited

Loading

IanButterworth commented Feb 12, 2025 •

edited

Loading