Skip to content

Conversation

@KristofferC
Copy link
Member

Revert "Fixes for julia_version. Expand and consolidate julia_version tests. (#4151)"

This commit causes CI errors on julia CI:

Test Failed at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/test/pkg.jl:982
  Expression: ensure_resolved(Pkg.Types.Context(), Pkg.Types.Manifest(), [p])
    Expected: Pkg.Types.PkgError("Package PackageSpec(\n  path = test_packages/Example\n  version = *\n) has neither name nor uuid")
      Thrown: Pkg.Types.PkgError("no active project")
      no active project
      Stacktrace:
        [1] pkgerror(msg::String)
          @ Pkg.Types /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/src/Types.jl:68
        [2] find_project_file(env::Nothing)
          @ Pkg.Types /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/src/Types.jl:204
        [3] Pkg.Types.EnvCache(env::Nothing)
          @ Pkg.Types /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/src/Types.jl:382
        [4] EnvCache
          @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/src/Types.jl:382 [inlined]
        [5] Pkg.Types.Context()
          @ Pkg.Types /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/src/Types.jl:444
        [6] top-level scope
          @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/test/pkg.jl:981
        [7] macro expansion
          @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Test/src/Test.jl:1771 [inlined]
        [8] macro expansion
          @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/test/pkg.jl:982 [inlined]
        [9] macro expansion
          @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Test/src/Test.jl:773 [inlined]
       [10] macro expansion
          @ /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-release-1-dot-12/julia-3e51f40bff/share/julia/stdlib/v1.12/Pkg/test/pkg.jl:982 [inlined]

@KristofferC KristofferC merged commit 7802601 into release-1.12 Jun 11, 2025
9 checks passed
@KristofferC KristofferC deleted the kc/revert_julia_version branch June 11, 2025 12:09
@IanButterworth
Copy link
Member

I'll fix this, but just to link the issue. The problem was this wasn't backported also #4154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants