Skip to content

Fix bind_artifact! when platform has compare_strategy #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 7 commits into from
Jul 2, 2025
Merged

Fix bind_artifact! when platform has compare_strategy #3624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b384d88
Fix bind_artifact! when platform has compare_strategy
glennmoy Sep 14, 2023
6ec585d
remove errant LOC
glennmoy Sep 14, 2023
2c203e7
fix method call
glennmoy Sep 14, 2023
7980456
qualify call to set_compare_strategy!
glennmoy Sep 14, 2023
e99df46
qualify call to compare_version_cap
glennmoy Sep 14, 2023
5dfc1ea
fix test
glennmoy Sep 14, 2023
69be1f6
Merge branch 'master' into gm/fix_bind_artifact
IanButterworth Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Artifacts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ function bind_artifact!(artifacts_toml::String, name::String, hash::SHA1;
meta = artifact_dict[name]
if !isa(meta, Vector)
error("Mapping for '$name' within $(artifacts_toml) already exists!")
elseif any(isequal(platform), unpack_platform(x, name, artifacts_toml) for x in meta)
elseif any(p -> platforms_match(platform, p), unpack_platform(x, name, artifacts_toml) for x in meta)
error("Mapping for '$name'/$(triplet(platform)) within $(artifacts_toml) already exists!")
end
end
Expand Down
6 changes: 6 additions & 0 deletions test/artifacts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,12 @@ end
@test ensure_artifact_installed("foo_txt", artifacts_toml; platform=linux64) == artifact_path(hash2)
@test ensure_artifact_installed("foo_txt", artifacts_toml; platform=win32) == artifact_path(hash)

# Default HostPlatform() adds a compare_strategy key that doesn't get picked up from
# the Artifacts.toml
testhost = Platform("x86_64", "linux", Dict("libstdcxx_version" => "1.2.3"))
BinaryPlatforms.set_compare_strategy!(testhost, "libstdcxx_version", BinaryPlatforms.compare_version_cap)
@test_throws ErrorException bind_artifact!(artifacts_toml, "foo_txt", hash; download_info=download_info, platform=testhost)

# Next, check that we can get the download_info properly:
meta = artifact_meta("foo_txt", artifacts_toml; platform=win32)
@test meta["download"][1]["url"] == "http://google.com/hello_world"
Expand Down