Fix bind_artifact! when platform has compare_strategy#3624
Merged
IanButterworth merged 7 commits intoJuliaLang:masterfrom Jul 2, 2025
Merged
Fix bind_artifact! when platform has compare_strategy#3624IanButterworth merged 7 commits intoJuliaLang:masterfrom
IanButterworth merged 7 commits intoJuliaLang:masterfrom
Conversation
glennmoy
commented
Sep 14, 2023
glennmoy
commented
Sep 14, 2023
IanButterworth
approved these changes
Jul 2, 2025
Member
IanButterworth
left a comment
IanButterworth
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Though I'll ping @staticfloat for visibility.
IanButterworth
added
merge me
staticfloat
approved these changes
Jul 2, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jul 4, 2025
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com> (cherry picked from commit 799f7de)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2026
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com> (cherry picked from commit 799f7de)
KristofferC
pushed a commit
that referenced
this pull request
Feb 23, 2026
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com> (cherry picked from commit 799f7de)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3623
Note: the instructions are missing the
Pkg.buildstep needed to make the tests work locally (hence the repeated pushes). Easy to miss,I will open a follow up PR to add it#3625.