names with kwargs #493
Merged
names with kwargs #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Feb 16, 2018
src/Compat.jl
Outdated
| @@ -1629,6 +1629,11 @@ else | |||
| findall(b::OccursIn, a::Number) = a in b.x ? [1] : Vector{Int}() | |||
| end | |||
|
|
|||
| # https://github.com/JuliaLang/julia/pull/25647 | |||
| @static if VERSION < v"0.7.0-DEV.3526" | |||
| Base.names(m; all=true, imported=true) = names(m, all, imported) | |||
There was a problem hiding this comment.
Is it kosher to overwrite Base methods like this? We could provide an unexported Compat.names with the appropriate signatures.
There was a problem hiding this comment.
Hmm.... right, this overwrites the one arg function? Lets just do the unexported thing then.
fredrikekre
force-pushed
the
fe/names
branch
from
98952df
to
9461e39
Compare
ararslan
reviewed
Feb 16, 2018
src/Compat.jl
Outdated
| @@ -1643,6 +1643,13 @@ else | |||
| findall(b::OccursIn, a::Number) = a in b.x ? [1] : Vector{Int}() | |||
| end | |||
|
|
|||
| # https://github.com/JuliaLang/julia/pull/25647 | |||
| @static if VERSION < v"0.7.0-DEV.3526" | |||
| names(m; all=true, imported=true) = names(m, all, imported) | |||
There was a problem hiding this comment.
The method that it calls might need a Base. qualification.
fredrikekre
force-pushed
the
fe/names
branch
from
9461e39
to
b254e77
Compare
omus
reviewed
Feb 17, 2018
| @@ -274,6 +274,8 @@ Currently, the `@compat` macro supports the following syntaxes: | |||
|
|
|||
| * `firstindex` to obtain the first index of an iterable ([#25458]). | |||
|
|
|||
| * `Compat.names` supporting keyword arguments for `all` and `imported` ([#25647]). | |||
There was a problem hiding this comment.
Do you need to add the full link at the bottom of the page?
fredrikekre
force-pushed
the
fe/names
branch
from
b254e77
to
f526085
Compare
mortenpi
reviewed
Feb 28, 2018
| @@ -1643,6 +1643,13 @@ else | |||
| findall(b::OccursIn, a::Number) = a in b.x ? [1] : Vector{Int}() | |||
| end | |||
|
|
|||
| # https://github.com/JuliaLang/julia/pull/25647 | |||
| @static if VERSION < v"0.7.0-DEV.3526" | |||
| names(m; all=true, imported=true) = Base.names(m, all, imported) | |||
There was a problem hiding this comment.
Should this not be names(m; all=false, imported=false) to be in line with 0.7?
This behaves differently on 0.6 and 0.7 right now:
import Compat
module Foo
import Base: copy
end
Compat.names(Foo)julia-0.7> Compat.names(Foo)
1-element Array{Symbol,1}:
:Foo
julia-0.6> Compat.names(Foo)
4-element Array{Symbol,1}:
Symbol("#eval")
:Foo
:copy
:eval
martinholters
added a commit
that referenced
this pull request
Oct 8, 2019
martinholters
added a commit
that referenced
this pull request
Oct 8, 2019
martinholters
added a commit
that referenced
this pull request
Oct 8, 2019
martinholters
added a commit
that referenced
this pull request
Oct 8, 2019
martinholters
added a commit
that referenced
this pull request
Oct 13, 2019
* Bump required Julia version to 1.0 * Remove compatibility support code for: * `at-__MODULE__` (from #363) * `devnull`, `stdin`, `stdout`, and `stderr` from #499 * `at-nospecialize` (from #385 and #409) * `isabstracttype` and `isconcretetype` (from #477) * `invokelatest` from #424 * array-like access to `Cmd` from #379 * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399 * `logdet(::Any)` fallback from #382 * `chol(::UniformScaling)` from #382 * `pushfirst!`, `popfirst!` from #444 * `fieldcount` from #386 * `read(obj, ::Type{String})` from #385 and #580 * `InexactError`, `DomainError`, and `OverflowError` constructors from #393 * `corrected` kw arg to `cov` from #401 * `adjoint` from #401 * `partialsort` from #401 * `pairs` from #428 * `AbstractRange` from #400 * `rtoldefault` from #401 * `Dates.Period` rounding from #462 * `IterativeEigensolvers` from #435 * `occursin` from #520 * `Char` concatenation from #406 * `BitSet` from #407 * `diagm` and `spdiagm` with pairs from #408 * `Array` c'tors from `UniformScaling` from #412 and #438 * `IOContext` ctor taking pairs from #427 * `undef` from #417 and #514 * `get` on `ENV` from #430 * `ComplexF...` from #431 * `tr` from #614 * `textwidth` from #644 * `isnumeric` from #543 * `AbstractDict` from #435 * `axes` #435 and #442 * `Nothing` and `Cvoid` from #435 * `Compat.SuiteSparse` from #435 * `invpermute!` from #445 * `replace` with a pair from #445 * `copyto!` from #448 * `contains` from #452 * `CartesianIndices` and `LinearIndices` from #446, #455, and #524 * `findall` from #466 (and #467). * `argmin` and `argmax` from #470, #472, and #622 * `parentmodule` from #461 * `codeunits` from #474 * `nameof` from #471 * `GC` from #477 * `AbstractDisplay` from #482 * `bytesavailable` from #483 * `firstindex` and `lastindex` from #480 and #494 * `printstyled` from #481 * `hasmethod` from #486 * `objectid` from #486 * `Compat.find*` from #484 and #513 * `repr` and `showable` from #497 * `Compat.names` from #493 and #505 * `Compat.round` and friends #500, #530, and #537 * `IOBuffer` from #501 and #504 * `range` with kw args and `LinRange` from #511 * `cp` and `mv` from #512 * `indexin` from #515 * `isuppercase` and friends from #516 * `dims` and `init` kwargs from #518, #528, #590, #592, and #613 * `selectdim` from #522 and #531 * `repeat` from #625 * `fetch(::Task)` from #549 * `isletter` from #542 * `isbitstype` from #560 * `at-cfunction` from #553 and #566 * `codeunit` and `thisind` and friends from #573 * `something` from #562 * `permutedims` from #582 * `atan` from #574 * `split` and `rsplit` from #572 * `mapslices` from #588 * `floatmin` and `floatmax` from #607 * `dropdims` from #618 * required keyword arguments from #586 * `CartesianRange` in `at-compat` from #377 * `finalizer` from #416 * `readline`, `eachline`, and `readuntil` from #477, #541, and #575 * curried `isequal`, `==`, and `in` from #517 * `Some` from #435 and #563 * `at-warn` and friends from #458 * Remove old deprecations * Deprecate: * `Compat.Sockets` from #545 and #594 * `TypeUtils` from #304 * `macros_have_sourceloc` from #355 * `Compat.Sys` from #380, #433, and #552 * `Compat.MathConstants` from #401 * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404 * `Compat.Dates` from #413 * `Compat.Libdl` from #465 (and #467) * `AbstractDateTime` from #443 * `Compat.Printf` from #435 * `Compat.LinearAlgebra` from #463 * `Compat.SparseArrays` from #459 * `Compat.Random` from #460, #601, and #647 * `Compat.Markdown` from #492 * `Compat.REPL` from #469 * `Compat.Serialization` from #473 * `Compat.Statistics` from #583 * `Fix2` from #517 * `Compat.Base64` from #418 * `Compat.Unicode` from #432 and #507 * `notnothing` from #435 and #563 * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451 * `enable_debug(::Bool)` from #458 * `Compat.Distributed` from #477 * `Compat.Pkg` from #485 * `Compat.InteractiveUtils` from #485 * `Compat.LibGit2` from #487 * `Compat.UUIDs` from #490 * `Compat.qr` from #534 * `Compat.rmul!` from #546 * `Compat.norm` abd friends from #577 * Remove obsolete README entry, missed in #385 * Remove obsolete tests (e.g. missed in #372) * Remove obsolete `VERSION` conditionals and some minor clean-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.