Changes invokelatest eval to run in current_module() #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
reviewed
May 16, 2017
test/runtests.jl
Outdated
| @@ -1870,6 +1870,8 @@ let | |||
| @test_throws MethodError Dates.Month(1) < Dates.Day(1) | |||
| end | |||
|
|
|||
| @test Compat.invokelatest(current_module) != Compat | |||
JobJob
force-pushed
the
invokelatest-current-module
branch
from
14e43e3
to
e22fae6
Compare
1 task
yuyichao
approved these changes
May 16, 2017
|
doh, my fault, sorry |
|
worth a patch release if you're in a hurry to use this in ijulia |
|
Okay, will tag a patch release. |
|
Tagged 0.25.1 (JuliaLang/METADATA.jl#9334) |
martinholters
added a commit
that referenced
this pull request
Sep 10, 2018
fredrikekre
pushed a commit
that referenced
this pull request
Sep 14, 2018
* `zeros` and `ones` with interface of `similar` (from #330) * `convert` between `Set` types (from #342) * `isassigned(::RefValue)` (from #345) * `unsafe_trunc(::Type{<:Integer}, ::Integer)` (from #344) * `bswap` for complex numbers (from #346) * Compat.StringVector (from #348) * `invokelatest` (from #352 and #359) * Misc. pre-0.6-only code * obsolete README enries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invokelatestruns in module Compat on julia 0.5, so this:returns
Compatin julia 0.5, but on 0.6-rc1.0 (which hasBase.invokelatestdefined) it returnsMain.After this PR they both return
Main.