Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport bswap method for complex numbers. #346

Merged
merged 2 commits into from
Apr 12, 2017

Conversation

traktofon
Copy link
Contributor

It was added to julia in PR#21346, commit b7836db.

Originally I had this method in my own package FortranFiles.jl (which also supports julia 0.5), but because this defines a Base method for a Base datatype, @tkelman suggested it might go into Base, and if accepted there, also into Compat.

It was added to julia in PR21346, commit b7836db4.
README.md Outdated
@@ -161,6 +161,8 @@ Currently, the `@compat` macro supports the following syntaxes:

* `unsafe_trunc(::Type{<:Integer}, ::Integer)` is supported on 0.5. ([#18629])

* `bswap` is supported for `Complex` arguments. ([#21346])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add "on 0.5 and earlier"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Compat now requires julia 0.4, I feel (but not very strongly) that specifying this is redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have integrated @TotalVerb's suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this is that some features are available only on 0.5, and not on 0.4 (see a good chunk of the broadcast stuff), so we should be clear that this works on both.

Copy link
Member

@stevengj stevengj Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the default should be that every Compat feature is supported on every Julia version indicated by the REQUIRES file (i.e. v0.4+ currently). A note should only be necessary when a given feature is not supported in 0.4.

@vchuravy vchuravy merged commit 47f5741 into JuliaLang:master Apr 12, 2017
@traktofon traktofon deleted the complex-bswap branch April 13, 2017 04:14
martinholters added a commit that referenced this pull request Sep 10, 2018
fredrikekre pushed a commit that referenced this pull request Sep 14, 2018
* `zeros` and `ones` with interface of `similar` (from #330)

* `convert` between `Set` types (from #342)

* `isassigned(::RefValue)` (from #345)

* `unsafe_trunc(::Type{<:Integer}, ::Integer)` (from #344)

* `bswap` for complex numbers (from #346)

* Compat.StringVector (from #348)

* `invokelatest` (from #352 and #359)

* Misc. pre-0.6-only code

* obsolete README enries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants