Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@compat for f.(args...) and foo.:bar #196

Merged
merged 2 commits into from
May 11, 2016
Merged

@compat for f.(args...) and foo.:bar #196

merged 2 commits into from
May 11, 2016

Conversation

stevengj
Copy link
Member

This adds compatibility for JuliaLang/julia#15032.

@@ -541,6 +541,22 @@ function _compat(ex::Expr)
callexpr.args[2] = params
callexpr.args[3] = obj
end
elseif VERSION < v"0.5.0-dev+4002" && ex.head == :. && length(ex.args) == 2 # 15032
if isexpr(ex.args[2], :quote) && typeof(ex.args[2].args[1]) == QuoteNode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isa(x, QuoteNode)

@timholy
Copy link
Member

timholy commented May 10, 2016

LGTM. The isa is basically stylistic, so feel free to go ahead and merge if you prefer.

@stevengj
Copy link
Member Author

Changed to isa. Merge when green.

@timholy timholy merged commit 5a822da into master May 11, 2016
@timholy
Copy link
Member

timholy commented May 11, 2016

Thanks!

@yuyichao yuyichao deleted the dot_broadcast branch May 11, 2016 01:38
martinholters pushed a commit to martinholters/Compat.jl that referenced this pull request Jul 13, 2016
Remove varzm and just use varm with m=0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants