-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
Overdue we required julia-0.4.
The ones in gen/ still remain
Another point worth making: start a julia session and run the tests. Then exit. On julia-0.4, exiting happens "instantly." On julia-0.5, there's a ~3.5 second delay before you get back to the linux prompt. Calling |
Given the travis backlog for JuliaLang, any objections if we move this package to https://github.com/JuliaGraphics? |
@@ -1,5 +1,9 @@ | |||
module GLib | |||
|
|||
if VERSION < v"0.5.0-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be more specific about version number cutoffs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just fitting in with the rest of the code 😄.
Thanks for working on this! I am still on 0.4 but will appreciate the smooth transition due to your effort |
Of course, the |
Most of this is tedious, but there are a couple that might be worth a look:
The one thing left to make this perfect 😄 on julia-0.5 would be to eliminate the overwritten function warnings in
gen/
.