Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

The big julia-0.5 update #231

Merged
merged 10 commits into from
May 10, 2016
Merged

The big julia-0.5 update #231

merged 10 commits into from
May 10, 2016

Conversation

timholy
Copy link
Member

@timholy timholy commented May 10, 2016

Most of this is tedious, but there are a couple that might be worth a look:

  • d9048f5: I was lazy and didn't check whether there is a better way
  • 11ae24d: is it weird this didn't cause an error before?

The one thing left to make this perfect 😄 on julia-0.5 would be to eliminate the overwritten function warnings in gen/.

@timholy
Copy link
Member Author

timholy commented May 10, 2016

Another point worth making: start a julia session and run the tests. Then exit. On julia-0.4, exiting happens "instantly." On julia-0.5, there's a ~3.5 second delay before you get back to the linux prompt. Calling gc() before exiting does not materially decrease this time.

@timholy
Copy link
Member Author

timholy commented May 10, 2016

Given the travis backlog for JuliaLang, any objections if we move this package to https://github.com/JuliaGraphics?

@@ -1,5 +1,9 @@
module GLib

if VERSION < v"0.5.0-dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be more specific about version number cutoffs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just fitting in with the rest of the code 😄.

@tknopp
Copy link
Collaborator

tknopp commented May 10, 2016

Thanks for working on this! I am still on 0.4 but will appreciate the smooth transition due to your effort

@timholy timholy merged commit a1cf0af into master May 10, 2016
@timholy timholy deleted the teh/julia-0.5 branch May 10, 2016 20:38
@timholy
Copy link
Member Author

timholy commented May 10, 2016

Of course, the f.(args) merger just introduced a whole bunch of new deprecations 😄, but I'll wait until JuliaLang/Compat.jl#196 merges and gets tagged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants