introduce sumfinite, enhancement to *finite, rename minfinite/maxfinite
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functionaility changes: * support `meanfinite([f=identity], A)` * add `sumfinite([f=identity], A)` * "fixes" `varfinite` for `RGB` array inputs using dot product Also add more comprehensive tests
* rename: `minfinite` -> `minimum_finite` * rename: `maxfinite` -> `maximum_finite` * add function argument to `minimum_finite` and `maximum_finite` * deprecate `maxabsfinite(A)` in favor of `maximum_finite(abs, A)` * support `minimum_finite(A; dims)` and `maximum_finite(A; dims) * more comprehensive tests
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 89.94% 90.40% +0.45%
==========================================
Files 6 6
Lines 189 198 +9
==========================================
+ Hits 170 179 +9
Misses 19 19
Continue to review full report at Codecov.
|
timholy
approved these changes
Sep 27, 2021
| @@ -61,14 +83,14 @@ if Base.VERSION >= v"1.1" | |||
| function varfinite(A; kwargs...) | |||
There was a problem hiding this comment.
Should we make this varmult_finite instead?
There was a problem hiding this comment.
A good suggestion, let me open an issue for it first and then fix it in a separate PR; this PR is already quite big actually.
Edit: issue opened #18
johnnychen94
added a commit
to JuliaImages/Images.jl
that referenced
this pull request
Oct 31, 2021
This commit moves some of the basic stats-related functions to ImageBase so that other packages don't need to depend on the large Images dependency. A few deprecations are involved to support the more generic version. See also: JuliaImages/ImageBase.jl#17 Co-authored-by: JohnnyChen <[email protected]>
johnnychen94
added a commit
to johnnychen94/Images.jl
that referenced
this pull request
May 21, 2022
This commit moves some of the basic stats-related functions to ImageBase so that other packages don't need to depend on the large Images dependency. A few deprecations are involved to support the more generic version. See also: JuliaImages/ImageBase.jl#17 Co-authored-by: JohnnyChen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
sumfinite([f=identity], A)meanfinite([f=identity], A)minimum_finite([f=identity], A)maximum_finite([f=identity], a)Bug fixes:
varfiniteforRGBarray inputs using dot product. This requires ColorVectorSpace v0.9.7minimum_finite(A; dims)andmaximum_finite(A; dims)Deprecations:
minfinite->minimum_finitemaxfinite->maximum_finitemaxabsfinite(A)in favor ofmaximum_finite(abs, A)There are some type infer issues, which I leave as future work.
Closes #14