Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ImageMagick_jll, add test for #206 #215

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

simeonschaub
Copy link
Collaborator

should also fix #158

@simeonschaub simeonschaub reopened this Feb 3, 2023
@simeonschaub
Copy link
Collaborator Author

Ah, I see, it's not tagged yet, Yggdrasil is still busy: https://buildkite.com/julialang/yggdrasil/builds/607

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36f956f) 75.73% compared to head (77b778d) 75.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   75.73%   75.51%   -0.23%     
==========================================
  Files           3        3              
  Lines         441      441              
==========================================
- Hits          334      333       -1     
- Misses        107      108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/constructed_images.jl Outdated Show resolved Hide resolved
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking down this! I've tested it locally that it fixes #206 for macOS.

test/constructed_images.jl Show resolved Hide resolved
@simeonschaub simeonschaub marked this pull request as draft February 5, 2023 17:31
@simeonschaub
Copy link
Collaborator Author

Unfortunately with the latest Ghostscript changes, loading a PDF now segfaults even if you have commandline gs available. @giordano Should we yank the latest ImageMagick_jll? Not really urgent though since ImageMagick.jl still caps the compat

@giordano
Copy link
Member

giordano commented Feb 5, 2023

Yes, it'd be good not to have totally unusable versions around.

@simeonschaub simeonschaub marked this pull request as ready for review February 5, 2023 19:49
@simeonschaub
Copy link
Collaborator Author

Ok, everything should be ready to go now

@simeonschaub
Copy link
Collaborator Author

@simeonschaub simeonschaub marked this pull request as draft February 5, 2023 19:51
@giordano
Copy link
Member

giordano commented Feb 5, 2023

@simeonschaub
Copy link
Collaborator Author

Do I need to be on a Windows system for that?

@giordano
Copy link
Member

giordano commented Feb 5, 2023

Yes. But you can use https://github.com/mxschmitt/action-tmate to get one

@giordano
Copy link
Member

giordano commented Feb 5, 2023

Well, there isn't much to do:

% file libgs-9.dll
libgs-9.dll: broken symbolic link to libgs-9-55.dll

@simeonschaub
Copy link
Collaborator Author

So is the issue that we forgot to copy the original file?

@simeonschaub simeonschaub reopened this Feb 6, 2023
@simeonschaub simeonschaub reopened this Feb 6, 2023
@jochalek
Copy link
Contributor

Is there anything still holding this up? I would like to help if possible.

@ViralBShah ViralBShah marked this pull request as ready for review February 17, 2024 17:17
@ViralBShah
Copy link
Contributor

I'm merging this in order to get things working on M1. Since all tests are passing here, I feel comfortable doing so - but should be easy enough to revert or update further.

@ViralBShah ViralBShah merged commit 62de7d3 into JuliaIO:master Feb 20, 2024
7 of 8 checks passed
@ViralBShah
Copy link
Contributor

ViralBShah commented Feb 20, 2024

Fixes #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot decode a J2K image format stream.
5 participants