Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update h5t_equal definition to automatically return Bool #761

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

jmert
Copy link
Contributor

@jmert jmert commented Dec 6, 2020

The change in #757 to Base.:(==)(::Datatype, ::Datatype) incorrectly
assumed that h5t_equal was already defined to return htri_t, so
it broke the return type of equality comparisons on datatypes.

The change in JuliaIO#757 to `Base.:(==)(::Datatype, ::Datatype)` incorrectly
assumed that `h5t_equal` was already defined to return `htri_t`, so
it broke the return type of equality comparisons on datatypes.
@musm musm merged commit 099c6cd into JuliaIO:master Dec 6, 2020
@jmert jmert deleted the equal_bool branch December 6, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants