Extend Base.hash rather than creating proviate hash
#757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither do I. This is legacy code that probably hasn't been touched since. I'm guessing this is probably fine/improvement. Feel free to merge. |
musm
reviewed
Dec 4, 2020
| @@ -289,7 +289,7 @@ function Reference(parent::Union{File,Group,Dataset}, name::AbstractString) | |||
| return Reference(ref[]) | |||
| end | |||
| Base.:(==)(a::Reference, b::Reference) = a.r == b.r | |||
| hash(x::Reference, h::UInt) = hash(x.r, h) | |||
There was a problem hiding this comment.
Since Reference is a struct is this even needed? (As opposed to Datatype which is mutable)
There was a problem hiding this comment.
Oh, good point. Probably not then.
jmert
added a commit
to jmert/HDF5.jl
that referenced
this pull request
Dec 6, 2020
The change in JuliaIO#757 to `Base.:(==)(::Datatype, ::Datatype)` incorrectly assumed that `h5t_equal` was already defined to return `htri_t`, so it broke the return type of equality comparisons on datatypes.
musm
pushed a commit
that referenced
this pull request
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working on something else. I'm not 100% sure I actually fully understand what
hashis supposed to be responsible for, but I took inspiration in updating theDatatypehash from AutoHashEquals.jl, using the type itself as part of the hash rather than the arbitrary constant.I could do the same for the
Referencehash, but it seems that thehobj_ref_tname/identity already gets hashed in automatically sincehash(h5obj_ref_t(1)) !== hash(1).