add PaddedDiskArray and pad
#219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meggart
requested changes
Feb 10, 2025
src/pad.jl
Outdated
| end | ||
|
|
||
| readblock!(A::PaddedDiskArray, data, I...) = _readblock_padded!(A, data, I...) | ||
| readblock!(A::PaddedDiskArray, data, I::AbstractVector...) = |
There was a problem hiding this comment.
Just curious why this is necessary, are the fallbacks too slow here?
There was a problem hiding this comment.
Not sure I understood this question, I think we need readblock! to fill the padding zeros/etc? Or should I do that another way?
There was a problem hiding this comment.
The comment was about the type signature of the arguments. I would suggest to do define readblock!(A::PaddedDiskArray, data, I::AbstractUnitRange{<:Int}...) and let DiskArrays figure out complicated cases like unsorted vectors.
|
@rafaqz do you need support for fixing some of the chunk issues? |
|
Should be ok, just haven't had time to get back to it yet |
|
@meggart I think this is good to go |
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ive had this use case a few times that you want to pad a disk array for windowing or fixing chunk alignment, and you don't want to make a copy of the file.
This PR adds a
PaddedDiskArraywrapper and aDiskArrays.padfunction that pads any disk array by custom amounts above and below the original array on each axis. The fill value for the padded area can be set with thefillkeyword, which is zero by default.Chunk offsets are updated to match the padding