Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DiskArrays.pad in extend when the parent isdisk #903

Open
rafaqz opened this issue Feb 19, 2025 · 3 comments
Open

Use DiskArrays.pad in extend when the parent isdisk #903

rafaqz opened this issue Feb 19, 2025 · 3 comments

Comments

@rafaqz
Copy link
Owner

rafaqz commented Feb 19, 2025

Waiting on JuliaIO/DiskArrays.jl#219

@rafaqz
Copy link
Owner Author

rafaqz commented Feb 19, 2025

Or possibly add a DiskArrays.pad method as instead? extend doesn't specify a padding value and assumes a writable array is returned.

pad would assume the exact semantics of DiskArrays.pad, and it would work without supplying new dimensions as long as the extended dims are Regular

@asinghvi17
Copy link
Collaborator

Extending pad sounds better for the specific use case you want. But we'll have to be very clear when documenting this and PaddedDiskArray should have a nice error when you try to write to it.

@rafaqz
Copy link
Owner Author

rafaqz commented Feb 19, 2025

Yeah, it already has an error message in writeblock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants